Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1909990: Port to machine-api-operator #78

Merged
merged 3 commits into from Dec 22, 2020
Merged

[release-4.6] Bug 1909990: Port to machine-api-operator #78

merged 3 commits into from Dec 22, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #75

/assign Gal-Zaidman

Gal-Zaidman added 3 commits December 22, 2020 09:22
port-to-mao(1): update go.mod and vendor
33b696b 
This is the vendor update that was required for porting to mao

Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>

bump-go-ovirt

Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
port-to-mao(2): update dockerfile and makefile
ee8f423 
Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
port-to-mao(3): code changes
9526089 
This commit contains the code/import changes that were required to port to mao

Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 22, 2020
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1897138 has been cloned as Bugzilla bug 1909990. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1909990: Port to machine-api-operator

In response to this:

[release-4.6] Bug 1897138: Port to machine-api-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1897138: Port to machine-api-operator [release-4.6] Bug 1909990: Port to machine-api-operator Dec 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 22, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1909990, which is invalid:

  • expected dependent Bugzilla bug 1897138 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1909990: Port to machine-api-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gal-Zaidman Gal-Zaidman added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Dec 22, 2020
@Gal-Zaidman
Copy link

/lgtm

@Gal-Zaidman
Copy link

/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gal-Zaidman, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2020
@dougsland dougsland merged commit 4de0406 into openshift:release-4.6 Dec 22, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1909990 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1909990: Port to machine-api-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennyz bennyz Awaiting requested review from bennyz

@rgolangh rgolangh Awaiting requested review from rgolangh

Assignees

@Gal-Zaidman Gal-Zaidman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @Gal-Zaidman @dougsland