Merge pull request #629 from liouk/fix-randombits

OCPBUGS-17987: generate only >=0 number of random bits
openshift · Oct 23, 2023 · 89f814e · 89f814e
2 parents 7ae04d4 + 1e7d7b1
commit 89f814e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/controllers/oauthclientscontroller/oauthclientscontroller.go b/pkg/controllers/oauthclientscontroller/oauthclientscontroller.go
@@ -146,7 +146,7 @@ func (c *oauthsClientsController) ensureBootstrappedOAuthClients(ctx context.Con
 	return nil
 }
 
-func randomBits(bits int) []byte {
+func randomBits(bits uint) []byte {
 	size := bits / 8
 	if bits%8 != 0 {
 		size++

diff --git a/pkg/controllers/oauthclientscontroller/oauthclientscontroller_test.go b/pkg/controllers/oauthclientscontroller/oauthclientscontroller_test.go
@@ -243,7 +243,7 @@ func Test_ensureBootstrappedOAuthClients(t *testing.T) {
 
 func Test_randomBits(t *testing.T) {
 	tests := []struct {
-		bits        int
+		bits        uint
 		expectedLen int
 	}{
 		{0, 0}, {1, 1}, {8, 1}, {16, 2}, {32, 4}, {64, 8}, {128, 16}, {256, 32}, {512, 64},