Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manifest annotations for hosted deployment exclusions #220

Merged
merged 1 commit into from Nov 26, 2019
Merged

Add manifest annotations for hosted deployment exclusions #220

merged 1 commit into from Nov 26, 2019

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Nov 25, 2019

Enables the CVO to exclude manifests in an externally hosted control plane deployment
See openshift/cluster-version-operator#252

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 25, 2019
@openshift-ci-robot
Copy link
Contributor

@csrwng: This pull request references Bugzilla bug 1776421, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead
  • expected Bugzilla bug 1776421 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1776421: Add manifest annotations for hosted deployment exclusions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2019
@csrwng
Copy link
Contributor Author

csrwng commented Nov 25, 2019

/assign @sttts

@csrwng
Copy link
Contributor Author

csrwng commented Nov 25, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@csrwng: This pull request references Bugzilla bug 1776421, which is invalid:

  • expected Bugzilla bug 1776421 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng csrwng changed the title Bug 1776421: Add manifest annotations for hosted deployment exclusions Add manifest annotations for hosted deployment exclusions Nov 25, 2019
@openshift-ci-robot
Copy link
Contributor

@csrwng: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add manifest annotations for hosted deployment exclusions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 25, 2019
@stlaz
Copy link
Member

stlaz commented Nov 26, 2019

Where's the enhancement for this?

@stlaz
Copy link
Member

stlaz commented Nov 26, 2019

/hold
This shan't merge without an enhancement

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2019
@csrwng
Copy link
Contributor Author

csrwng commented Nov 26, 2019

Because of timing, this change is meant to be part of an internal API for now. It will be eventually replaced by an official enhancement in 4.4 (CVO profiles).

@stlaz
Copy link
Member

stlaz commented Nov 26, 2019

/hold stop
/lgtm

I see. Who would I be to stop a well-meant internal API change. Please note that I will consider reverting if the enhancement does not arrive in 4.4 enhancement freeze time.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2019
@stlaz
Copy link
Member

stlaz commented Nov 26, 2019

/retest

@stlaz stlaz mentioned this pull request Nov 26, 2019
Merged
@stlaz
Copy link
Member

stlaz commented Nov 26, 2019

/hold cancel
because /hold stop will not work obviously

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 914647f into openshift:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz Awaiting requested review from stlaz

@sttts sttts Awaiting requested review from sttts

Assignees

@stlaz stlaz

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@csrwng @openshift-ci-robot @stlaz @openshift-bot @sttts @openshift-merge-robot