bump kube to 1.17 and pull latest library-go #232
Conversation
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
stlaz
force-pushed
the
bump_kube_and_such
branch
from
6b2ade1
to
c22cbdc
Compare
|
/test e2e-aws |
| @@ -1,4 +1,4 @@ | |||
| FROM registry.svc.ci.openshift.org/openshift/release:golang-1.12 AS builder | |||
| FROM registry.svc.ci.openshift.org/openshift/release:golang-1.13 AS builder | |||
There was a problem hiding this comment.
I'd drop this whole file as we have done in other repos. There is no OKD yet and registry.svc.ci.openshift.org/openshift/origin-v4.0:base is actually OCP anyways
There was a problem hiding this comment.
CI was using wrong dockerfile, pls drop it in a followup
go.mod
Outdated
| ) | ||
|
|
||
| replace ( | ||
| github.com/openshift/api => github.com/openshift/api v3.9.1-0.20191209132752-992bc3a41fe6+incompatible | ||
| github.com/openshift/client-go => github.com/openshift/client-go v0.0.0-20191205152420-9faca5198b4f | ||
| github.com/openshift/library-go => github.com/openshift/library-go v0.0.0-20191211124107-e0f1590a316e | ||
| github.com/openshift/library-go => github.com/openshift/library-go v0.0.0-20200103110434-cd8a585d2a77 |
stlaz
force-pushed
the
bump_kube_and_such
branch
from
c22cbdc
to
43c4442
Compare
|
@tnozicka I think I will be able to drop Dockerfile only after the dependent CI PR merged edit: the second comment should be addressed now |
stlaz
force-pushed
the
bump_kube_and_such
branch
from
43c4442
to
fc61233
Compare
Also bumps rhel7 Dockerfile base to 4.4
stlaz
force-pushed
the
bump_kube_and_such
branch
from
fc61233
to
875aa2d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Building the operator images fails because OSBS builders are disconnected from the internets but the builder image tries to use go mod and fails on dependency pulls.
Latest library-go forces using the vendor directory in builds.
This PR also bumps the builder images in Dockerfiles to golang-1.13
cc @tnozicka @sanchezl @vareti