Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add only a basic config observer #242

Merged
merged 8 commits into from Apr 2, 2020
Merged

Add only a basic config observer #242

merged 8 commits into from Apr 2, 2020

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Jan 15, 2020

This config observer PR leaves out the tricky oauth/cluster bits of #222 to get this merged faster

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 15, 2020
@stlaz
Copy link
Member Author

stlaz commented Jan 15, 2020 •
edited

opening now just to see which tests fail while I observe whether the rebased commits are reasonable

@stlaz
Copy link
Member Author

stlaz commented Jan 15, 2020

/cc @p0lyn0mial

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@stlaz stlaz changed the title [WIP] Add only a basic config observer Add only a basic config observer Jan 16, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2020
@stlaz
Copy link
Member Author

stlaz commented Jan 16, 2020

tests are passing and the observed config looks reasonable: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-authentication-operator/242/pull-ci-openshift-cluster-authentication-operator-master-e2e-aws/946/artifacts/e2e-aws/must-gather/registry-svc-ci-openshift-org-ci-op-vbh60z1w-stable-sha256-dd03a9e0ac7b6e710037d8f0d0a5001b47c27bf859e49b0256e8ac54f5bd8198/namespaces/openshift-authentication/core/configmaps.yaml

@stlaz
Copy link
Member Author

stlaz commented Jan 16, 2020

Removed some unnecessary comments in the latest revision

@stlaz
Copy link
Member Author

stlaz commented Jan 16, 2020

/retest
weird error about an unbound variable of some bash script?

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 21, 2020
@stlaz
Copy link
Member Author

stlaz commented Jan 21, 2020

@sttts I updated the PR to use the CORS observer from lib-go

@stlaz
Copy link
Member Author

stlaz commented Jan 21, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2020
@stlaz
Copy link
Member Author

stlaz commented Apr 1, 2020

Addressed comments + added a unit test to each of the observers that should make sure we don't spam update events as seen elsewhere.

@stlaz
Copy link
Member Author

stlaz commented Apr 1, 2020

/hold cancel
deps merged

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2020
@stlaz
Copy link
Member Author

stlaz commented Apr 1, 2020

/retest

@stlaz
Copy link
Member Author

stlaz commented Apr 1, 2020

/retest
something/someone seem to have interrupted the testing container

@sttts
Copy link
Contributor

sttts commented Apr 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, stlaz, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stlaz
Copy link
Member Author

stlaz commented Apr 1, 2020

/test e2e-aws-operator

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 79b4c66 into openshift:master Apr 2, 2020
@stlaz stlaz deleted the basic_configobserver branch July 2, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marun marun marun left review comments

@sttts sttts sttts left review comments

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@sttts sttts

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@stlaz @p0lyn0mial @sttts @openshift-ci-robot @openshift-bot @marun @openshift-merge-robot