Refactor existing controller to use controller factory #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* openshift/api@482e9764: auth: mark AccessTokenInactivityTimeoutSeconds deprecated * openshift/api@fe36e035: make update * openshift/api@aa7345a7: config/v1: add apiserver spec+status descriptions * openshift/api@124b41ac: config/v1: add authentication spec+status descriptions * openshift/api@d93d185d: Update CRDs * openshift/api@1b19b0f5: Bug 1784151: set additionalPrinterColumns for SCC * openshift/api@2bd66cee: bump to kube v1.18.3 * openshift/client-go@96dc5c6d: Bump to kube v1.18.2 * openshift/client-go@815a092d: bump to kube v1.18.3 * openshift/library-go@f2030b8d: Fix ClusterOperator event when version changes * openshift/library-go@65abf9cb: Bug 1832143: Prevent noisy events for ovirt cloud provider * openshift/library-go@fe935f67: Fix node controller - missing Ready condition * openshift/library-go@6395cfd1: Fix staticpod controller to use service ca from prometheus * openshift/library-go@226a5f43: make update-bindata * openshift/library-go@a4b1c3e3: factory: add bare informer * openshift/library-go@b051b252: cloudprovider: add oVirt to list of recognized cloud providers * openshift/library-go@735536f9: bump to kube v1.18.3 * openshift/library-go@2877d58d: double memory resource request and limits values * openshift/library-go@ed3d6fc7: Update interrupted InProgress revisions to Abandoned * openshift/library-go@fe841e66: reaper: Switch to a periodic reaping strategy * openshift/library-go@b4382ebd: factory: do not report synthetic requeue requests as errors * openshift/library-go@f098babd: use factory.SyntheticRequeueError when controllers retry * openshift/library-go@06e7719b: pkg/operator/render: grammar fixes * openshift/library-go@5d1c08c8: bump(*): add github.com/robfig/cron * openshift/library-go@b7381cf7: factory: add scheduled resync * openshift/library-go@e367ad25: allow disabling leader election in ControllerCommandConfig * openshift/library-go@dda47c8e: encryption-test: log an error while waiting for the migration controller * openshift/library-go@f20bcc42: factory: allow multiple scheduled times for sync * openshift/library-go@54705a04: Handle storage types in staticresourcecontroller * openshift/library-go@af23769d: eventwatch: add controller * openshift/library-go@10cf9dd4: operatorclient: add interface method to get metadata * openshift/library-go@32f013e5: eventwatch: process events with increasing counter
stlaz
approved these changes
Jun 26, 2020
| @@ -197,52 +184,3 @@ func verifyWithAnyCertificate(serverCerts []*x509.Certificate, options x509.Veri | |||
| // no certificate was able to verify dns name, return last error | |||
| return err | |||
| } | |||
|
|
|||
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.