Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor metadata to separate controller (part 1) #292

Merged
merged 4 commits into from Jul 4, 2020
Merged

Refactor metadata to separate controller (part 1) #292

merged 4 commits into from Jul 4, 2020

Conversation

mfojtik
Copy link
Member

@mfojtik mfojtik commented Jun 26, 2020 •
edited

This holds a ground work for splitting the main operator loop into more granular controllers based on controller factory.

To preserve order (temporarely), the operator progressing conditions are used. Note that this will eventually go away after all blocks are split (in this PR the first blocks is separated to its own controller).

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2020
@mfojtik
Copy link
Member Author

mfojtik commented Jun 26, 2020

/hold

stop retesting this.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2020
@mfojtik mfojtik force-pushed the refactor-metadata branch 4 times, most recently from c90e1cc to ca6d33d Compare June 26, 2020 16:02
@mfojtik mfojtik force-pushed the refactor-metadata branch 2 times, most recently from d6815ef to 4513e5d Compare June 29, 2020 07:41
@mfojtik mfojtik mentioned this pull request Jun 29, 2020
Merged
@mfojtik mfojtik changed the title WIP: DO_NOT_MERGE: Refactor metadata to separate controller Refactor metadata to separate controller Jun 29, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2020
@mfojtik
Copy link
Member Author

mfojtik commented Jun 29, 2020

/hold cancel

This is green and provide ground work.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2020
@mfojtik
Copy link
Member Author

mfojtik commented Jun 29, 2020

/retest

1 similar comment
@mfojtik
Copy link
Member Author

mfojtik commented Jun 29, 2020

/retest

@mfojtik
Copy link
Member Author

mfojtik commented Jun 29, 2020

storage tests flaking

stlaz
stlaz requested changes Jun 29, 2020
View reviewed changes
pkg/controllers/metadata/metadata_controller.go Outdated Show resolved Hide resolved
pkg/controllers/metadata/metadata_controller.go Outdated Show resolved Hide resolved
pkg/controllers/metadata/metadata_controller.go Outdated Show resolved Hide resolved
pkg/controllers/metadata/metadata_controller.go Outdated Show resolved Hide resolved
pkg/controllers/metadata/metadata_controller.go Outdated Show resolved Hide resolved
pkg/operator2/operator.go Show resolved Hide resolved
@mfojtik
Copy link
Member Author

mfojtik commented Jun 30, 2020

/retest

infra registry flake

@mfojtik mfojtik changed the title Refactor metadata to separate controller Refactor metadata to separate controller (part 1) Jun 30, 2020
@mfojtik
Copy link
Member Author

mfojtik commented Jul 2, 2020

@stlaz updated

stlaz
stlaz requested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@stlaz stlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash the last commit to the previous, move the condition that's not being set to stale and lets' get this merged

pkg/controllers/readiness/wellknown_ready_controller.go Outdated
// These conditions are operated and defaulted by this controller.
// Any new condition used by this controller sync() loop should be listed here.
var knownConditionNames = sets.NewString(
"WellKnownEndpointDegraded",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you don't set it to true, move it to Stale conditions

@stlaz
Copy link
Member

stlaz commented Jul 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Member Author

mfojtik commented Jul 3, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8bb2e80 into openshift:master Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz stlaz requested changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@stlaz stlaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mfojtik @stlaz @openshift-ci-robot @openshift-bot @openshift-merge-robot