authentication operator is marked available because the deployment is missing #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
|
/lgtm |
stlaz
approved these changes
Aug 12, 2020
| Type: "WellKnownAvailable", | ||
| Status: operatorv1.ConditionFalse, | ||
| Reason: "PrereqsNotReady", | ||
| Message: "THe well-known endpoint prereqs are not yet available", |
| if userMetadataConfig := authConfig.Spec.OAuthMetadata.Name; authConfig.Spec.Type != configv1.AuthenticationTypeIntegratedOAuth || len(userMetadataConfig) != 0 { | ||
| return true, "", nil | ||
| // the operator manages the metadata if specifically requested and by default | ||
| isOperatorManagedMetadata := authConfig.Spec.Type == configv1.AuthenticationTypeIntegratedOAuth || len(authConfig.Spec.Type) == 0 |
There was a problem hiding this comment.
good catch with that empty type, I wonder how long we had this there
| routev1informers "github.com/openshift/client-go/route/informers/externalversions/route/v1" | ||
| routev1listers "github.com/openshift/client-go/route/listers/route/v1" | ||
| operatorv1 "github.com/openshift/api/operator/v1" | ||
|
|
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the CVO treats availability as "past the post", this cause a blip which disturbs the installation flow.