bug 1875038: endpointaccessible: do not panic when no endpoints are found #334
Conversation
| // the endpoint list function can return empty results without error when the endpoints does not exists | ||
| // requeue in that case and wait until we get valid endpoints to check. | ||
| if len(endpoints) == 0 { | ||
| return factory.SyntheticRequeueError |
There was a problem hiding this comment.
if this is the case, we should be degraded. This shouldn't be a synthentic error.
There was a problem hiding this comment.
if this is the case, we should be degraded. This shouldn't be a synthentic error.
actuall, set the AVailable to false.
There was a problem hiding this comment.
@deads2k updated, we go available=false in case no endpoints are returned.
mfojtik
force-pushed
the
fix-endpoints-check
branch
from
abc2766
to
9339c59
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
deads2k
changed the title
openshift-ci-robot
added
bugzilla/severity-urgent
|
@mfojtik: This pull request references Bugzilla bug 1875038, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mfojtik: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1875038 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.