Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1877960: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found #342

Merged
merged 2 commits into from Sep 17, 2020
Merged

Bug 1877960: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found #342

merged 2 commits into from Sep 17, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #288

/assign marun

@stlaz
router-secrets: set named certificates to empty array instead of nil …
961ee30 
…when none found

This prevents spamming errors in the observer when no certificates are
found in the router secret.
@stlaz
don't cache e2e tests
e5454a4
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 10, 2020
Merged
@marun
Copy link
Contributor

marun commented Sep 10, 2020

/retitle Bug 1876919: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found Bug 1876919: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found Sep 10, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 10, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1876919, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "---" instead
  • expected Bugzilla bug 1876919 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1876919: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 10, 2020
@marun
Copy link
Contributor

marun commented Sep 10, 2020

/retitle Bug 1877928: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found

@openshift-ci-robot openshift-ci-robot changed the title Bug 1876919: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found Bug 1877928: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found Sep 10, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1877928, which is invalid:

  • expected dependent Bugzilla bug 1876919 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1876919 to target a release in 4.6.0, 4.6.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1877928: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun
Copy link
Contributor

marun commented Sep 10, 2020

/retitle Bug 1877960: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found

@openshift-ci-robot openshift-ci-robot changed the title Bug 1877928: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found Bug 1877960: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found Sep 10, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Sep 10, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1877960, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "4.6.0" instead
  • expected dependent Bugzilla bug 1877952 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1877960: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun
Copy link
Contributor

marun commented Sep 10, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@marun: This pull request references Bugzilla bug 1877960, which is invalid:

  • expected dependent Bugzilla bug 1877952 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun
Copy link
Contributor

marun commented Sep 16, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Sep 16, 2020
@openshift-ci-robot
Copy link
Contributor

@marun: This pull request references Bugzilla bug 1877960, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1877952 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1877952 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 16, 2020
@stlaz
Copy link
Member

stlaz commented Sep 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@markmc
Copy link

markmc commented Sep 17, 2020

Relatively trivial and safe change to make debugging easier

@markmc markmc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 17, 2020
@openshift-merge-robot openshift-merge-robot merged commit f13ebf8 into openshift:release-4.5 Sep 17, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1877960 has been moved to the MODIFIED state.

In response to this:

Bug 1877960: [release-4.5] router-secrets: set named certificates to empty array instead of nil when none found

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@marun marun

@stlaz stlaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @marun @openshift-ci-robot @stlaz @markmc @openshift-merge-robot