Bug 1880345: Provide more details for deployment pods #351
Conversation
|
/retest |
1 similar comment
|
/retest |
mfojtik
changed the title
openshift-ci-robot
added
the
bugzilla/severity-unspecified
|
@mfojtik: This pull request references Bugzilla bug 1880345, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/severity-high
|
@mfojtik: This pull request references Bugzilla bug 1880345, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/operator/starter.go
Outdated
| @@ -147,6 +148,7 @@ func RunOperator(ctx context.Context, controllerContext *controllercmd.Controlle | |||
| operatorCtx.resourceSyncController = resourceSyncer | |||
| operatorCtx.operatorClient = operatorClient | |||
| operatorCtx.operatorConfigInformer = configinformer.NewSharedInformerFactoryWithOptions(configClient, resync) | |||
| operatorCtx.kubeInformers = informers.NewSharedInformerFactory(operatorCtx.kubeClient, 10*time.Minute) | |||
There was a problem hiding this comment.
why do we need kubeInformersForNamespaces and kubeInformers ?
There was a problem hiding this comment.
be sure that you don't watch pods for all namespaces.
|
/hold the informers needs to be reconsidered |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
* openshift/library-go@4c9c5c8d: apps: add human readable deployment pod containers status helper * openshift/library-go@17489bd9: workloads: wire deployment pod containers status details * openshift/library-go@00062517: Fix reading of CRD v1 * openshift/library-go@2ff9e0f8: v1helpers: add namespaced informer for pods * openshift/library-go@7c22d4bb: workload: switch to use pod lister instead of passing full informer factory
…ster operator status
mfojtik
force-pushed
the
deployment-status-bump
branch
from
f16c863
to
fd393d6
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@mfojtik: All pull requests linked via external trackers have merged: Bugzilla bug 1880345 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.