Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1916949: manifests: exclude rbac resources in openshift-oauth-apiserver namespace from hosted profile #399

Merged
merged 1 commit into from Jan 21, 2021
Merged

Bug 1916949: manifests: exclude rbac resources in openshift-oauth-apiserver namespace from hosted profile #399

merged 1 commit into from Jan 21, 2021

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Jan 15, 2021 •
edited

@sjenning sjenning force-pushed the exclude-prom-rbac-hosted-profile branch from 6351b6b to f33c878 Compare January 15, 2021 22:26
@sjenning sjenning changed the title manifests: exclude rbac resources in openshift-oauth-apiserver namespace from hosted profile Bug 1916949: manifests: exclude rbac resources in openshift-oauth-apiserver namespace from hosted profile Jan 15, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 15, 2021
@openshift-ci-robot
Copy link
Contributor

@sjenning: This pull request references Bugzilla bug 1916949, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1916949: manifests: exclude rbac resources in openshift-oauth-apiserver namespace from hosted profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@sjenning: This pull request references Bugzilla bug 1916949, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1916949: manifests: exclude rbac resources in openshift-oauth-apiserver namespace from hosted profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng
Copy link
Contributor

csrwng commented Jan 15, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021
@csrwng
Copy link
Contributor

csrwng commented Jan 15, 2021

/assign @sttts

@sjenning sjenning force-pushed the exclude-prom-rbac-hosted-profile branch from f33c878 to 62b40ef Compare January 15, 2021 22:58
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021
@sjenning
Copy link
Contributor Author

had to add the ServiceMonitor as well

@csrwng
Copy link
Contributor

csrwng commented Jan 15, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021
@sttts
Copy link
Contributor

sttts commented Jan 18, 2021

This needs lgtm from monitoring team, who own this domain.

/assign @s-urbaniak

@s-urbaniak
Copy link
Contributor

/approve

@s-urbaniak
Copy link
Contributor

/retest

@s-urbaniak
Copy link
Contributor

/lgtm

@sttts
Copy link
Contributor

sttts commented Jan 20, 2021

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, s-urbaniak, sjenning, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@csrwng
Copy link
Contributor

csrwng commented Jan 21, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 4fd4212 into openshift:master Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

@sjenning: All pull requests linked via external trackers have merged:

Bugzilla bug 1916949 has been moved to the MODIFIED state.

In response to this:

Bug 1916949: manifests: exclude rbac resources in openshift-oauth-apiserver namespace from hosted profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning sjenning mentioned this pull request Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@s-urbaniak s-urbaniak

@sttts sttts

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sjenning @openshift-ci-robot @csrwng @sttts @s-urbaniak @openshift-bot @openshift-merge-robot