Bug 2037274: pkg/operator#LegacyCNCerts: use increase function #544

s-urbaniak · 2022-02-11T09:59:49Z

Since counters are monotonic, their values are not reset, hence we have to use the increase function to detect faulty certificates. Here, a window of 30 minutes has been chosen to have a good reaction time after certs have been corrected.

/cc @stlaz

openshift-ci · 2022-02-11T09:59:54Z

@s-urbaniak: This pull request references Bugzilla bug 2037274, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
expected dependent Bugzilla bug 2037272 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (NOTABUG) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2037274: pkg/operator#LegacyCNCerts: use increase function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

s-urbaniak · 2022-02-11T10:00:02Z

If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.
- verified
- does not apply
The bug has significant impact either through severity, reduction in supportability, or number of users affected.
- verified
- does not apply
For branches that are in the Maintenance lifecycle phase:
- The bug is a critical fix, no reasonable workaround exists, and a recommendation for upgrade has been ruled out, or
- The bug is a security related bug
- Branch not in maintenance mode yet (current release + previous release for 90 days after current GA; everything older is in maintenance)
The severity field of the bug must be set to accurately reflect criticality.
- verified
The PR was created with the cherry-pick bot OR the PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.
- verified

s-urbaniak · 2022-02-11T10:01:00Z

/bugzilla refresh

openshift-ci · 2022-02-11T10:01:04Z

@s-urbaniak: This pull request references Bugzilla bug 2037274, which is invalid:

expected dependent Bugzilla bug 2037272 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (NOTABUG) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

s-urbaniak · 2022-02-11T10:11:03Z

/bugzilla refresh

openshift-ci · 2022-02-11T10:15:22Z

@s-urbaniak: This pull request references Bugzilla bug 2037274, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2031839 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2031839 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tkashem · 2022-02-11T14:13:46Z

/lgtm
/approve

stlaz · 2022-02-14T08:45:41Z

/lgtm

openshift-ci · 2022-02-14T08:47:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, stlaz, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [stlaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-02-14T09:52:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-14T10:04:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-02-14T10:07:36Z

@s-urbaniak: This pull request references Bugzilla bug 2037274, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2031839 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2031839 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

Bug 2037274: pkg/operator#LegacyCNCerts: use increase function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-02-14T10:16:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-14T10:52:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-01T00:39:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-01T02:16:30Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-01T02:27:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-01T03:03:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-01T03:15:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-01T04:03:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-01T04:27:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-01T05:51:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-01T06:03:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

stlaz · 2022-03-01T08:04:03Z

/hold
e2e-operator test needs to be fixed

s-urbaniak · 2022-03-01T08:18:17Z

/hold

s-urbaniak · 2022-03-10T09:29:58Z

/retest

s-urbaniak · 2022-03-10T09:30:11Z

/hold cancel

openshift-bot · 2022-03-10T10:10:31Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-10T12:07:30Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-10T16:27:31Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-10T17:44:30Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-10T21:32:31Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T00:08:29Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T01:57:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T02:57:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T03:33:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T03:45:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-03-11T04:04:19Z

@s-urbaniak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-ipv6	`d1319dc`	link	false	`/test e2e-agnostic-ipv6`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-03-11T04:06:31Z

@s-urbaniak: All pull requests linked via external trackers have merged:

Bugzilla bug 2037274 has been moved to the MODIFIED state.

In response to this:

Bug 2037274: pkg/operator#LegacyCNCerts: use increase function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested a review from stlaz February 11, 2022 09:59

openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 11, 2022

s-urbaniak added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 11, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 11, 2022

openshift-ci bot requested a review from xingxingxia February 11, 2022 10:15

s-urbaniak force-pushed the increase branch from de07490 to 85b4f3a Compare February 11, 2022 10:18

openshift-ci bot assigned tkashem Feb 11, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2022

pkg/operator#LegacyCNCerts: use increase function

d1319dc

s-urbaniak force-pushed the increase branch from 85b4f3a to d1319dc Compare February 14, 2022 08:43

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2022

openshift-ci bot assigned stlaz Feb 14, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022

openshift-ci bot mentioned this pull request Mar 10, 2022

Bug 2037274: pkg/operator#LegacyCNCerts: use increase function openshift/cluster-kube-apiserver-operator#1318

Merged

openshift-merge-robot merged commit 086c06f into openshift:release-4.9 Mar 11, 2022

s-urbaniak deleted the increase branch March 14, 2022 12:16

Bug 2037274: pkg/operator#LegacyCNCerts: use increase function #544

Bug 2037274: pkg/operator#LegacyCNCerts: use increase function #544

Conversation

s-urbaniak commented Feb 11, 2022 • edited

openshift-ci bot commented Feb 11, 2022

s-urbaniak commented Feb 11, 2022

s-urbaniak commented Feb 11, 2022

openshift-ci bot commented Feb 11, 2022

s-urbaniak commented Feb 11, 2022

openshift-ci bot commented Feb 11, 2022

tkashem commented Feb 11, 2022

stlaz commented Feb 14, 2022

openshift-ci bot commented Feb 14, 2022

openshift-bot commented Feb 14, 2022

openshift-bot commented Feb 14, 2022

openshift-ci bot commented Feb 14, 2022

openshift-bot commented Feb 14, 2022

openshift-bot commented Feb 14, 2022

openshift-bot commented Mar 1, 2022

openshift-bot commented Mar 1, 2022

openshift-bot commented Mar 1, 2022

openshift-bot commented Mar 1, 2022

openshift-bot commented Mar 1, 2022

openshift-bot commented Mar 1, 2022

openshift-bot commented Mar 1, 2022

openshift-bot commented Mar 1, 2022

openshift-bot commented Mar 1, 2022

stlaz commented Mar 1, 2022

s-urbaniak commented Mar 1, 2022

s-urbaniak commented Mar 10, 2022

s-urbaniak commented Mar 10, 2022

openshift-bot commented Mar 10, 2022

openshift-bot commented Mar 10, 2022

openshift-bot commented Mar 10, 2022

openshift-bot commented Mar 10, 2022

openshift-bot commented Mar 10, 2022

openshift-bot commented Mar 11, 2022

openshift-bot commented Mar 11, 2022

openshift-bot commented Mar 11, 2022

openshift-bot commented Mar 11, 2022

openshift-bot commented Mar 11, 2022

openshift-ci bot commented Mar 11, 2022

openshift-ci bot commented Mar 11, 2022

s-urbaniak commented Feb 11, 2022 •

edited