Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console and kube api server operator informers: skip cache sync #57

Merged

Conversation

enj
Copy link
Contributor

@enj enj commented Feb 1, 2019

Enhance controller boilerplate

  1. Be strict on how long we wait for caches to sync
  2. Add support for opting out of informer cache sync
  3. Add support for initial event to prime sync loop

Signed-off-by: Monis Khan mkhan@redhat.com


console and kube api server operator informers: skip cache sync

The CRDs backing these resources may not exist. We do not want to wedge the operator on them.

Signed-off-by: Monis Khan mkhan@redhat.com


/assign @mrogers950

1. Be strict on how long we wait for caches to sync
2. Add support for opting out of informer cache sync
3. Add support for initial event to prime sync loop

Signed-off-by: Monis Khan <mkhan@redhat.com>
The CRDs backing these resources may not exist.  We do not want to
wedge the operator on them.

Signed-off-by: Monis Khan <mkhan@redhat.com>
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. lgtm Indicates that a PR is ready to be merged. labels Feb 1, 2019
Copy link
Contributor

@mrogers950 mrogers950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, mrogers950

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6fce50a into openshift:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants