-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate operator config CRD to openshift/api/operator/v1 #58
Conversation
After client-go generation, do a bump(*), drop old type and generated code, drop old CRD, update old CR to new GVR. |
|
149e08c
to
4d0ccec
Compare
appsv1 "k8s.io/api/apps/v1" | ||
corev1 "k8s.io/api/core/v1" | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
"k8s.io/apimachinery/pkg/util/intstr" | ||
"k8s.io/apimachinery/pkg/util/sets" | ||
) | ||
|
||
const hashAnnotation = authv1alpha1.GroupName + "/rvs-hash" | ||
var hashAnnotation = operatorv1.GroupName + "/rvs-hash" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sallyom as a followup, make operatorv1.GroupName
a const
in openshift/api
and then undo this change.
/lgtm Tested with htpasswd |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, sallyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Migrate operator config CRD
see:
@enj
The above merged, this PR has 3 commits:
/hold