Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove top level config CRDs #62

Merged

Conversation

enj
Copy link
Contributor

@enj enj commented Feb 6, 2019

These have moved to cluster-config-operator.

Signed-off-by: Monis Khan mkhan@redhat.com

@deads2k

These have moved to cluster-config-operator.

Signed-off-by: Monis Khan <mkhan@redhat.com>
@deads2k
Copy link
Contributor

deads2k commented Feb 6, 2019

/lgtm
/hold

you'll want to wait for the cluster-config-operator changes

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. lgtm Indicates that a PR is ready to be merged. labels Feb 6, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2019
@stlaz
Copy link
Member

stlaz commented Feb 6, 2019

@enj
Copy link
Contributor Author

enj commented Feb 7, 2019

/hold cancel
/test all

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2019
@enj
Copy link
Contributor Author

enj commented Feb 8, 2019

/retest

3 similar comments
@stlaz
Copy link
Member

stlaz commented Feb 8, 2019

/retest

@stlaz
Copy link
Member

stlaz commented Feb 8, 2019

/retest

@stlaz
Copy link
Member

stlaz commented Feb 8, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 04af67d into openshift:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants