Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-13346: dont log jwt tokens #622

Merged
merged 2 commits into from Jul 24, 2023
Merged

OCPBUGS-13346: dont log jwt tokens #622

merged 2 commits into from Jul 24, 2023

Conversation

ibihim
Copy link
Contributor

@ibihim ibihim commented Jul 10, 2023

What

  • Bump library-go

Why

  • Contains updated audit policies to not log tokens.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 10, 2023
@openshift-ci-robot
Copy link
Contributor

@ibihim: This pull request references Jira Issue OCPBUGS-13342, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.12.z" version, but it targets "4.13.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead
  • expected Jira Issue OCPBUGS-13342 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What

  • Bump library-go

Why

  • Contains updated audit policies to not log tokens.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ibihim ibihim force-pushed the OCPBUGS-13342-dont_log_jwt_tokens branch from 1bedff7 to f84d862 Compare July 10, 2023 14:09
@xingxingxia
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 10, 2023
@openshift-ci openshift-ci bot requested review from deads2k and stlaz July 10, 2023 14:24
@stlaz
Copy link
Member

stlaz commented Jul 17, 2023

/hold
contains _output directory

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
stlaz
stlaz reviewed Jul 17, 2023
View reviewed changes
_output/golang-versions Outdated
@@ -0,0 +1,3 @@
1.19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the _output dir

@ibihim ibihim force-pushed the OCPBUGS-13342-dont_log_jwt_tokens branch from f84d862 to 3ca9edb Compare July 17, 2023 11:41
@stlaz
Copy link
Member

stlaz commented Jul 17, 2023

/hold cancel
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibihim, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@ibihim
Copy link
Contributor Author

ibihim commented Jul 17, 2023

/retest-required

1 similar comment
@ibihim
Copy link
Contributor Author

ibihim commented Jul 18, 2023

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023 •
edited

@ibihim: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 3ca9edb link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ibihim
Copy link
Contributor Author

ibihim commented Jul 19, 2023

/retest-required

@ibihim ibihim changed the title OCPBUGS-13342: dont log jwt tokens OCPBUGS-13346: dont log jwt tokens Jul 20, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 20, 2023
@openshift-ci-robot
Copy link
Contributor

@ibihim: This pull request references Jira Issue OCPBUGS-13346, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13763 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13763 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (zhozhang@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What

  • Bump library-go

Why

  • Contains updated audit policies to not log tokens.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 20, 2023
@ibihim
Copy link
Contributor Author

ibihim commented Jul 20, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@ibihim: This pull request references Jira Issue OCPBUGS-13346, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13763 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13763 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (zhozhang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stlaz
Copy link
Member

stlaz commented Jul 24, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 24, 2023
@openshift-merge-robot openshift-merge-robot merged commit fe4212a into openshift:release-4.12 Jul 24, 2023
13 of 14 checks passed
@openshift-ci-robot
Copy link
Contributor

@ibihim: Jira Issue OCPBUGS-13346: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-13346 has not been moved to the MODIFIED state.

In response to this:

What

  • Bump library-go

Why

  • Contains updated audit policies to not log tokens.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ibihim ibihim deleted the OCPBUGS-13342-dont_log_jwt_tokens branch July 24, 2023 07:26
@ibihim ibihim restored the OCPBUGS-13342-dont_log_jwt_tokens branch July 24, 2023 07:26
@ibihim ibihim deleted the OCPBUGS-13342-dont_log_jwt_tokens branch July 24, 2023 07:26
@ibihim ibihim restored the OCPBUGS-13342-dont_log_jwt_tokens branch July 24, 2023 07:26
This was referenced Jul 24, 2023
Merged
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-07-24-141637

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-authentication-operator-container-v4.12.0-202311220908.p0.gfe4212a.assembly.stream for distgit ose-cluster-authentication-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz stlaz left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@stlaz stlaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ibihim @openshift-ci-robot @xingxingxia @stlaz @openshift-merge-robot @openshift-bot