Redeploy when a secret/configmap from top-level config changes #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/M
stlaz
commented
Feb 11, 2019
|
|
||
| // deployment, have RV of all resources | ||
| // TODO use ExpectedDeploymentGeneration func | ||
| // TODO manually get RV of all the config maps and secrets in syncData | ||
| // TODO we also need the RV for the serving-cert secret (servingCertName) |
There was a problem hiding this comment.
Isn't the CA bundle enough?
There was a problem hiding this comment.
The serving-cert could be rotated independently of the CA.
|
/retest |
ericavonb
approved these changes
Feb 12, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ericavonb, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redeploys the osin server if any of the configMaps and secrets in the top-level config changed.
Manually tested.