OCPBUGS-32089: wellknown-readiness: perform several attempts to connect before going unavailable

[stlaz]

cc @openshift/openshift-team-auth

[openshift-ci-robot]

@stlaz: This pull request references Jira Issue OCPBUGS-20056, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

cc @openshift/openshift-team-auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stlaz]

/jira refresh

[openshift-ci-robot]

@stlaz: This pull request references Jira Issue OCPBUGS-20056, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stlaz]

/jira refresh

[openshift-ci-robot]

@stlaz: This pull request references Jira Issue OCPBUGS-20056, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[wking]

Checking the update run, the intervals chart shows auth blipping Available=False late in the update during the machine-config node-reboot phase, when the incoming operator with your patch should be running:

The associated test-case has:

: [bz-apiserver-auth] clusteroperator/authentication should not change condition/Available expand_less
Run #0: Failed expand_less	1h31m45s
{  0 unexpected clusteroperator state transitions during e2e test run, as desired.
6 unwelcome but acceptable clusteroperator state transitions during e2e test run.  These should not happen, but because they are tied to exceptions, the fact that they did happen is not sufficient to cause this test-case to fail:

Apr 09 13:38:29.711 E clusteroperator/authentication condition/Available reason/APIServices_Error status/False APIServicesAvailable: apiservices.apiregistration.k8s.io/v1.user.openshift.io: not available: endpoints for service/api in "openshift-oauth-apiserver" have no addresses with port name "https" (exception: https://issues.redhat.com/browse/OCPBUGS-20056)
Apr 09 13:38:29.711 - 4s    E clusteroperator/authentication condition/Available reason/APIServices_Error status/False APIServicesAvailable: apiservices.apiregistration.k8s.io/v1.user.openshift.io: not available: endpoints for service/api in "openshift-oauth-apiserver" have no addresses with port name "https" (exception: https://issues.redhat.com/browse/OCPBUGS-20056)
Apr 09 13:38:33.922 W clusteroperator/authentication condition/Available reason/AsExpected status/True All is well (exception: Available=True is the happy case)
Apr 09 14:27:45.436 E clusteroperator/authentication condition/Available reason/APIServices_PreconditionNotReady status/False APIServicesAvailable: PreconditionNotReady (exception: https://issues.redhat.com/browse/OCPBUGS-20056)
Apr 09 14:27:45.436 - 77ms  E clusteroperator/authentication condition/Available reason/APIServices_PreconditionNotReady status/False APIServicesAvailable: PreconditionNotReady (exception: https://issues.redhat.com/browse/OCPBUGS-20056)
Apr 09 14:27:45.514 W clusteroperator/authentication condition/Available reason/AsExpected status/True All is well (exception: Available=True is the happy case)
}

Is that not the check you are tweaking? Feel free to shard into multiple bugs if you want to take several incremental steps, but you probably want to either save the OCPBUGS-20056 name for the final step or follow any sharding up with a bump to the origin exception list to track your later tickets.

[stlaz]

@wking This patch is focusing on the problem reported in OCPBUGS-20056, which is the check of the kube-apiserver's wellknown oauth endpoint. The issue from your report appears to be misattributing the bug to other problems. If you want those addressed, please open a different bug report.

[wking]

This patch is focusing on the problem reported in OCPBUGS-20056, which is the check of the kube-apiserver's wellknown oauth endpoint.

That's all I had room for in the title, but the Description has (since 2023-11-28) included:

And simplifying by looking only at reason:

curl -s 'https://search.ci.openshift.org/search?maxAge=48h&type=junit&name=4.15.*upgrade&context=0&search=clusteroperator/authentication.*condition/Available.*status/False' | jq -r 'to_entries[].value | to_entries[].value[].context[]' | sed 's|.*clusteroperator/\([^ ]*\) condition/Available reason/\([^ ]*\) status/False.*|\1 \2|' | sort | uniq -c | sort -n
     1 authentication APIServerDeployment_PreconditionNotFulfilled
     6 authentication OAuthServerDeployment_NoDeployment
     8 authentication APIServerDeployment_NoDeployment
    10 authentication APIServerDeployment_NoPod
    11 authentication WellKnown_NotReady
    36 authentication OAuthServerRouteEndpointAccessibleController_EndpointUnavailable
    43 authentication APIServices_PreconditionNotReady
    66 authentication OAuthServerServiceEndpointAccessibleController_EndpointUnavailable
    95 authentication APIServices_Error

Expected results:

Authentication goes Available=False if and only if immediate admin intervention is appropriate.

Which covered both of the reason picked up in this pull's CI run. If you want me to do the sharding, were you looking for one bug for each reason? Or would you like me to split things up differently?

[stlaz]

I see. I've only considered the fix of the WellKnown condition in the bug given it's description. That's about the amount of work that we can commit to for 4.16.

@wking If I might ask you to open another bug that tracks all the conditions and the name is a bit more generic (e.g. single short-lived operand blip shouldn't cause authentication operator available=false), that'd be great.

[stlaz]

/retest

[stlaz]

/retest

[wking]

I've cloned OCPBUGS-32089 off of OCPBUGS-20056. I retitled OCPBUGS-20056 to make that the generic one, because re-titling this pull to link the new ticket is easier than updating the test-suite exception bug reference.

/retitle OCPBUGS-32089: wellknown-readiness: perform several attempts to connect before going unavailable

[openshift-bot]

@stlaz: This pull request references Jira Issue OCPBUGS-32089, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @dpuniaredhat

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

cc @openshift/openshift-team-auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stlaz]

/retest-required

[liouk]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liouk, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [stlaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@stlaz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-ipv6	9a861be	link	false	/test e2e-agnostic-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

@stlaz: Jira Issue OCPBUGS-32089: All pull requests linked via external trackers have merged:

• openshift/cluster-authentication-operator#664

Jira Issue OCPBUGS-32089 has been moved to the MODIFIED state.

In response to this:

cc @openshift/openshift-team-auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-authentication-operator-container-v4.16.0-202404120544.p0.gaf38991.assembly.stream.el9 for distgit ose-cluster-authentication-operator.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-04-13-070448