Bug 1779745: Don't suppress errors when reporting operator status #127
Conversation
Previously errors applying updates to the operator's ClusterOperator status were silently ignored. This is mostly a problem when there's an error reporting the Available status, because there is no immediate retry in that case, which leaves the CVO unaware of the operator's success. This changes the reporter to always log errors applying the updates, and to retry in the case the case of an error applying the Available status.
|
@bison: This pull request references Bugzilla bug 1779745, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
openshift-ci-robot
added
the
size/S
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh The requirements for Bugzilla bugs have changed, recalculating validity. |
|
@openshift-bot: This pull request references Bugzilla bug 1779745, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@bison: This pull request references Bugzilla bug 1779745, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sdodson
added
the
cherry-pick-approved
|
@bison: All pull requests linked via external trackers have merged. Bugzilla bug 1779745 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Previously errors applying updates to the operator's ClusterOperator
status were silently ignored. This is mostly a problem when there's
an error reporting the Available status, because there is no immediate
retry in that case, which leaves the CVO unaware of the operator's
success. This changes the reporter to always log errors applying the
updates, and to retry in the case the case of an error applying the
Available status.
Cherry-pick of:
#124
#125
#126