Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1880302: Bump K8s dependencies to v1.19.0 #166

Merged
merged 1 commit into from Sep 22, 2020

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Sep 18, 2020

Our dependencies are out of date and should be on K8s 1.19.0 before the 4.6 release to match the rest of the core components. This PR updates all of the K8s and openshift depdendencies to include the lastest 1.19.0 release.
This address https://bugzilla.redhat.com/show_bug.cgi?id=1880302 and https://bugzilla.redhat.com/show_bug.cgi?id=1877743

@openshift-ci-robot
Copy link
Contributor

@enxebre: This pull request references Bugzilla bug 1880302, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1880302: Bump K8s dependencies to v1.19.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 18, 2020
@enxebre
Copy link
Member Author

enxebre commented Sep 18, 2020

/retest

@p0lyn0mial
Copy link

@enxebre
Copy link
Member Author

enxebre commented Sep 18, 2020

@enxebre https://bugzilla.redhat.com/show_bug.cgi?id=1880302 targets release 4.5

We need a ticket targeting 4.6 even though this was first found in 4.5 https://bugzilla.redhat.com/show_bug.cgi?id=1880302.
The clone targeting 4.5.z is here https://bugzilla.redhat.com/show_bug.cgi?id=1880320

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2020
@enxebre
Copy link
Member Author

enxebre commented Sep 18, 2020

/retest

github.com/openshift/library-go v0.0.0-20200917093739-70fa806b210a
github.com/stretchr/testify v1.5.1
k8s.io/api v0.19.0
k8s.io/apimachinery v0.19.0
k8s.io/client-go v12.0.0+incompatible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this dependency? It's very old and they have changed how the release versions on client-go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9c0dac7 into openshift:master Sep 22, 2020
@openshift-ci-robot
Copy link
Contributor

@enxebre: All pull requests linked via external trackers have merged:

Bugzilla bug 1880302 has been moved to the MODIFIED state.

In response to this:

Bug 1880302: Bump K8s dependencies to v1.19.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants