New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1880302: Bump K8s dependencies to v1.19.0 #166
Conversation
@enxebre: This pull request references Bugzilla bug 1880302, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
d754f7b
to
3fd59a3
Compare
@enxebre https://bugzilla.redhat.com/show_bug.cgi?id=1880302 targets release 4.5 |
We need a ticket targeting 4.6 even though this was first found in 4.5 https://bugzilla.redhat.com/show_bug.cgi?id=1880302. |
3fd59a3
to
9ca370e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
github.com/openshift/library-go v0.0.0-20200917093739-70fa806b210a | ||
github.com/stretchr/testify v1.5.1 | ||
k8s.io/api v0.19.0 | ||
k8s.io/apimachinery v0.19.0 | ||
k8s.io/client-go v12.0.0+incompatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update this dependency? It's very old and they have changed how the release versions on client-go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the one applying is this one https://github.com/openshift/cluster-autoscaler-operator/pull/166/files#diff-37aff102a57d3d7b797f152915a6dc16L23 v0.19.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@enxebre: All pull requests linked via external trackers have merged: Bugzilla bug 1880302 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Our dependencies are out of date and should be on K8s 1.19.0 before the 4.6 release to match the rest of the core components. This PR updates all of the K8s and openshift depdendencies to include the lastest 1.19.0 release.
This address https://bugzilla.redhat.com/show_bug.cgi?id=1880302 and https://bugzilla.redhat.com/show_bug.cgi?id=1877743