Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bugzilla component to OWNERS #172

Merged
merged 1 commit into from Oct 15, 2020

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Oct 8, 2020

This change adds the bugzilla component name to the OWNERS file to
comply with the prodsec requirements for OpenShift builds through ART.

@elmiko
Copy link
Contributor Author

elmiko commented Oct 8, 2020

/cherry-pick release-4.6
/cherry-pick release-4.5

@openshift-cherrypick-robot

@elmiko: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6
/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Contributor Author

elmiko commented Oct 8, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot

@elmiko: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Contributor Author

elmiko commented Oct 8, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot

@elmiko: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor

Should we also be including the subcomponent on this?

@elmiko
Copy link
Contributor Author

elmiko commented Oct 9, 2020

for this one i think we should not include the subcomponent. subcomponent is optional and the cao could be related in bugzilla to other providers as well (eg ovirt, openstack).

@JoelSpeed
Copy link
Contributor

Technically I think we should have a separate component for CAO, but I would expect any bug that is for the CAO (not the CA) to be related to the cluster-infrastructure team, not any provider team in particular

@elmiko
Copy link
Contributor Author

elmiko commented Oct 9, 2020

i tend to agree about having a separate component, or maybe just a separate subcomponent. imo, considering that "subcomponent" in the OWNERS is optional, we should opt to not use it to ensure we aren't over-scoping.

@JoelSpeed
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm cancel

@michaelgugino
Copy link
Contributor

I don't think the subcomponent is actually optional. BZ usually complains when I try to create a bug without setting it.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@elmiko
Copy link
Contributor Author

elmiko commented Oct 13, 2020

I don't think the subcomponent is actually optional. BZ usually complains when I try to create a bug without setting it.

in the docs for changing the OWNERS file it said that "component" is required, but "subcomponent" is optional. i can't link the doc here, but this is the relevant section:

# Bugillza fields at the same level. 

# Required. The repo's associated Bugillza component. e.g.:
component: "Networking"

# Optional. Specify only if the repo is associated with a subcomponent e.g.:
subcomponent: "multus"

# Unusual. Specify only if your Bugzilla product is not OCP
product: "..."

my thinking here is that since CAO could be associated with provider like bare metal or openstack, we should leave the subcomponent empty.

This change adds the bugzilla component name to the OWNERS file to
comply with the prodsec requirements for OpenShift builds through ART.
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit b84b575 into openshift:master Oct 15, 2020
@openshift-cherrypick-robot

@elmiko: new pull request created: #173

In response to this:

/cherry-pick release-4.6
/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@elmiko: new pull request created: #174

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@elmiko: new pull request created: #175

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko elmiko deleted the update-owners branch October 15, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants