New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add machineset/scale resource to the cluster-autoscaler role #177
Conversation
This change updates the ClusterRole for the cluster-autoscaler to include the resource `machineset/scale` for list/get/update/watch verbs. The new resource is being added to support the change in the autoscaler to remove structure types[0]. [0] openshift/kubernetes-autoscaler#177
this change is required for openshift/kubernetes-autoscaler#177 to work properly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
This change updates the ClusterRole for the cluster-autoscaler to
include the resource
machineset/scale
for list/get/update/watchverbs. The new resource is being added to support the change in the
autoscaler to remove structure types[0].
[0] openshift/kubernetes-autoscaler#177