Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCPCLOUD-1153] add a tombstones manifest to the install directory #214

Merged
merged 1 commit into from Jul 22, 2021

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Jul 15, 2021

CVO has added the ability to remove objects created in previous releases
of OpenShift. This change adds a manifest to remove old objects which
are no longer used by the cluster-autoscaler-operator.

ref: https://issues.redhat.com/browse/OTA-395

CVO has added the ability to remove objects created in previous releases
of OpenShift. This change adds a manifest to remove old objects which
are no longer used by the cluster-autoscaler-operator.

ref: https://issues.redhat.com/browse/OTA-395
@JoelSpeed
Copy link
Contributor

/approve

Based on my understanding of the CVO feature, I believe this to be correct

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2021
@jottofar
Copy link

LGTM

@JoelSpeed
Copy link
Contributor

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@JoelSpeed
Copy link
Contributor

/override ci/prow/e2e-aws-operator

We know that the webhook tests that failed in the last test run https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-autoscaler-operator/214/pull-ci-openshift-cluster-autoscaler-operator-master-e2e-aws-operator/1418168440492920832 are permabroken right now, we are working on a fix for this.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2021

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-operator

In response to this:

/override ci/prow/e2e-aws-operator

We know that the webhook tests that failed in the last test run https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-autoscaler-operator/214/pull-ci-openshift-cluster-autoscaler-operator-master-e2e-aws-operator/1418168440492920832 are permabroken right now, we are working on a fix for this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 1de0ee4 into openshift:master Jul 22, 2021
@elmiko elmiko deleted the tombstones branch July 22, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants