Bug 1986090: Do not recreate CA deployment when CA CR is being deleted

[JoelSpeed]

This is breaking our tests which use foreground deletion. The CAO fights the GC to delete and recreate the deployment, ensuring that the CA CR never goes away.

I have manually verified that this fixes the broken cluster autoscaler tests we are currently seeing in CI.

[openshift-ci]

@JoelSpeed: This pull request references Bugzilla bug 1986090, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 1986090: Do not recreate CA deployment when CA CR is being deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@JoelSpeed: This pull request references Bugzilla bug 1986090, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 1986090: Do not recreate CA deployment when CA CR is being deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elmiko]

this looks like a good solution, just curious if we could add a unit test to check the deletion time stamp part of this?

[JoelSpeed]

just curious if we could add a unit test to check the deletion time stamp part of this?

Reasonable request! I did have a look and our unit tests right now are a bit not great in this area, so it won't be trivial to add a test for this. I will look into adding a unit test for this tomorrow though.

[elmiko]

Reasonable request! I did have a look and our unit tests right now are a bit not great in this area, so it won't be trivial to add a test for this. I will look into adding a unit test for this tomorrow though.

sounds good, i was hoping we could slip this into the reconcile test but maybe that was optimistic of me ;)

[JoelSpeed]

/test e2e-upgrade

[alexander-demicev]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexander-demichev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lobziik]

/lgtm

[JoelSpeed]

/override ci/prow/e2e-aws-operator

The tests are broken, I've manually verified this, once this merged we can get the rest of the tests fixed

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-operator

In response to this:

/override ci/prow/e2e-aws-operator

The tests are broken, I've manually verified this, once this merged we can get the rest of the tests fixed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@JoelSpeed: All pull requests linked via external trackers have merged:

• openshift/cluster-autoscaler-operator#215

Bugzilla bug 1986090 has been moved to the MODIFIED state.

In response to this:

Bug 1986090: Do not recreate CA deployment when CA CR is being deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@JoelSpeed: new pull request created: #217

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.