Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Disabling ExpectClusterAutoscalerAvailable e2e test temporarily." #41

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Revert "Disabling ExpectClusterAutoscalerAvailable e2e test temporarily." #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions test/e2e/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,11 @@ func runSuite() error {
}
glog.Info("PASS: CreateClusterAutoscaler")

// TODO: Disabled temporarily, remove after https://github.com/openshift/kubernetes-autoscaler/pull/29 got merged.
// Since openshift installer is using machine.openshift.io instead of cluster.k8s.io,
// above PR can't be merged yet due to circualr dependency. Commented out test allows this PR #35 to get merged.
// if err := ExpectClusterAutoscalerAvailable(); err != nil {
// glog.Errorf("FAIL: ExpectClusterAutoscalerAvailable: %v", err)
// return err
// }
// glog.Info("PASS: ExpectClusterAutoscalerAvailable")
if err := ExpectClusterAutoscalerAvailable(); err != nil {
glog.Errorf("FAIL: ExpectClusterAutoscalerAvailable: %v", err)
return err
}
glog.Info("PASS: ExpectClusterAutoscalerAvailable")

return nil
}