-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unregistered types from supported target types #44
Conversation
This might hide the case where a user forgets to deploy machineset crd. Worth documenting it somewhere. Or, maybe to make at least one of machineset or machinedeployment crds exists. If not, fail? |
I don't want to try to do anything too clever, but we could check that there is at least one supported type found otherwise return an error. Does that sound like a reasonable compromise? |
+1 |
This checks for errors resulting from unregistered types when initializing the MachineAutoscaler reconciler and removes them from the list of supported target types.
I agree with @bison is out of the scope to deploy SupportedTargetGVKs CRD list |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/test e2e-aws-operator |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
This checks for errors resulting from unregistered types when
initializing the MachineAutoscaler reconciler and removes them from
the list of supported target types.