Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unregistered types from supported target types #44

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Remove unregistered types from supported target types #44

merged 1 commit into from
Feb 8, 2019

Conversation

bison
Copy link
Contributor

@bison bison commented Feb 8, 2019

This checks for errors resulting from unregistered types when
initializing the MachineAutoscaler reconciler and removes them from
the list of supported target types.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 8, 2019
@ingvagabund
Copy link
Member

This might hide the case where a user forgets to deploy machineset crd. Worth documenting it somewhere. Or, maybe to make at least one of machineset or machinedeployment crds exists. If not, fail?

@bison
Copy link
Contributor Author

bison commented Feb 8, 2019

This might hide the case where a user forgets to deploy machineset crd. Worth documenting it somewhere. Or, maybe to make at least one of machineset or machinedeployment crds exists. If not, fail?

I don't want to try to do anything too clever, but we could check that there is at least one supported type found otherwise return an error. Does that sound like a reasonable compromise?

@ingvagabund
Copy link
Member

I don't want to try to do anything too clever, but we could check that there is at least one supported type found otherwise return an error. Does that sound like a reasonable compromise?

+1

This checks for errors resulting from unregistered types when
initializing the MachineAutoscaler reconciler and removes them from
the list of supported target types.
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2019
@enxebre
Copy link
Member

enxebre commented Feb 8, 2019

I agree with @bison is out of the scope to deploy SupportedTargetGVKs CRD list
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2019
@ingvagabund
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2019
@frobware
Copy link
Contributor

frobware commented Feb 8, 2019

/test e2e-aws-operator
/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d10deb8 into openshift:master Feb 8, 2019
@bison bison deleted the unknown-types branch February 11, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants