Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VirtualMediaViaExternalNetwork flag to the Provisioning CRD #150

Merged
merged 1 commit into from Jun 23, 2021
Merged

Add VirtualMediaViaExternalNetwork flag to the Provisioning CRD #150

merged 1 commit into from Jun 23, 2021

Conversation

sadasu
Copy link
Contributor

@sadasu sadasu commented Jun 3, 2021

No description provided.

@sadasu
Copy link
Contributor Author

sadasu commented Jun 3, 2021

/hold
this is a 4.9 feature

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2021
@openshift-ci openshift-ci bot requested review from andfasano and markmc June 3, 2021 20:09
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2021
sadasu
sadasu commented Jun 3, 2021
View reviewed changes
api/v1alpha1/provisioning_types.go
@@ -54,6 +54,7 @@ type ProvisioningSpec struct {
// ProvisioningNetworkCIDR is the network on which the
// baremetal nodes are provisioned. The provisioningIP and the
// IPs in the dhcpRange all come from within this network.
// IPv6 networks cannot be larger than a /64.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should have been part of #145. Adding it here so that the generated manifest contained the documentation change that was intended for the above PR.
I also believe that this check for IPv6 network size could be added as an additional validation.

@sadasu
Copy link
Contributor Author

sadasu commented Jun 22, 2021

/retest

@sadasu
Copy link
Contributor Author

sadasu commented Jun 22, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2021
asalkeld
asalkeld reviewed Jun 22, 2021
View reviewed changes
Copy link
Contributor

@asalkeld asalkeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@sadasu
Copy link
Contributor Author

sadasu commented Jun 23, 2021

/test e2e-metal-ipi-ovn-ipv6

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2021
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 23, 2021
@asalkeld
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit b9d2b96 into openshift:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalkeld asalkeld asalkeld left review comments

@andfasano andfasano Awaiting requested review from andfasano

@markmc markmc Awaiting requested review from markmc

Assignees

@asalkeld asalkeld

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sadasu @openshift-bot @asalkeld @openshift-merge-robot