Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1972291: Use a cache URL with the .svc.cluster.local suffix #161

Merged
merged 1 commit into from Jul 8, 2021
Merged

[release-4.7] Bug 1972291: Use a cache URL with the .svc.cluster.local suffix #161

merged 1 commit into from Jul 8, 2021

Conversation

derekhiggins
Copy link
Contributor

By default cluster.local is part of NoProxy, using the longer
version ensure we match the NoProxy variable and keep the traffic
internal.

Backports:#147

@derekhiggins
Use a cache URL with the .svc.cluster.local suffix
7a95365 
By default cluster.local is part of NoProxy, using the longer
version ensure we match the NoProxy variable and keep the traffic
internal.
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@derekhiggins: This pull request references Bugzilla bug 1972291, which is invalid:

  • expected the bug to target the "4.7.z" release, but it targets "4.7.0" instead
  • expected Bugzilla bug 1972291 to depend on a bug targeting a release in 4.8.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1972291: Use a cache URL with the .svc.cluster.local suffix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from andfasano and zaneb June 15, 2021 16:21
@derekhiggins
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@derekhiggins: This pull request references Bugzilla bug 1972291, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1962592 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1962592 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zaneb
Copy link
Member

zaneb commented Jun 16, 2021

/retitle [release-4.7] Bug 1972291: Use a cache URL with the .svc.cluster.local suffix
/approve

@openshift-ci openshift-ci bot changed the title Bug 1972291: Use a cache URL with the .svc.cluster.local suffix [release-4.7] Bug 1972291: Use a cache URL with the .svc.cluster.local suffix Jun 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@asalkeld
Copy link
Contributor

/retest

1 similar comment
@sadasu
Copy link
Contributor

sadasu commented Jun 21, 2021

/retest

@sadasu
Copy link
Contributor

sadasu commented Jun 21, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@sadasu
Copy link
Contributor

sadasu commented Jun 22, 2021

/override ci/prow/e2e-metal-ipi-upgrade

Known issues with the upgrade CI job

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

@sadasu: Overrode contexts on behalf of sadasu: ci/prow/e2e-metal-ipi-upgrade

In response to this:

/override ci/prow/e2e-metal-ipi-upgrade

Known issues with the upgrade CI job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 23, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Member

mfojtik commented Jun 24, 2021

⚠️ The cherry-pick-approved label was removed by patch manager because this pull request failed to merge within approved merge window.\n
Next patch manager should investigate this and apply the label again, if the CI on this pull request is passing.'

@mfojtik mfojtik removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 24, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@derekhiggins
Copy link
Contributor Author

/hold
until the upgrade job is working

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2021
@sadasu
Copy link
Contributor

sadasu commented Jun 25, 2021

/test e2e-metal-ipi-upgrade

@sadasu
Copy link
Contributor

sadasu commented Jul 2, 2021

/test e2e-metal-ipi-upgrade
Several fixes have landed in 4.7 in the past week.

@sadasu
Copy link
Contributor

sadasu commented Jul 2, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2021
@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit cb7d1e4 into openshift:release-4.7 Jul 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2021

@derekhiggins: All pull requests linked via external trackers have merged:

Bugzilla bug 1972291 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1972291: Use a cache URL with the .svc.cluster.local suffix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@sadasu sadasu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@derekhiggins @zaneb @asalkeld @sadasu @openshift-bot @mfojtik @bparees @knobunc @openshift-merge-robot