Bug 1975711: Only start static ip set if provisioning net not disabled #166

derekhiggins · 2021-06-24T09:30:59Z

Only add metal3-static-ip-set if we have a provisioning ip and
and provisioning network is enabled. This brings the check for
both metal3-static-ip-set and metal3-static-ip-manager inline
with each other. It doesn't make sense to have one without the
other.

Only add metal3-static-ip-set if we have a provisioning ip and and provisioning network is enabled. This brings the check for both metal3-static-ip-set and metal3-static-ip-manager inline with each other. It doesn't make sense to have one without the other.

openshift-ci · 2021-06-24T09:31:05Z

@derekhiggins: This pull request references Bugzilla bug 1975711, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sadasu · 2021-06-29T15:02:23Z

/retest

openshift-ci · 2021-06-29T15:09:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sadasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dhellmann · 2021-06-29T17:45:31Z

/uncc dhellmann

asalkeld

/retest
/lgtm

asalkeld · 2021-06-30T00:29:31Z

/bugzilla refresh

openshift-ci · 2021-06-30T00:29:38Z

@asalkeld: This pull request references Bugzilla bug 1975711, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1972753 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Bugzilla bug 1972753 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-06-30T05:26:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-30T12:30:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-30T15:06:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-30T18:31:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-30T22:17:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-01T09:56:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-01T18:11:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

asalkeld

/lgtm

sdodson · 2021-07-22T18:39:31Z

Re-validating bugzilla status after prow config updates.
/bugzilla refresh

openshift-ci · 2021-07-22T18:39:36Z

@sdodson: This pull request references Bugzilla bug 1975711, which is invalid:

expected dependent Bugzilla bug 1972753 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-22T01:01:03Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-22T01:01:08Z

@openshift-bot: This pull request references Bugzilla bug 1975711, which is invalid:

expected dependent Bugzilla bug 1972753 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-23T01:01:00Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-23T01:01:06Z

@openshift-bot: This pull request references Bugzilla bug 1975711, which is invalid:

expected dependent Bugzilla bug 1972753 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-24T01:01:32Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-24T01:01:37Z

@openshift-bot: This pull request references Bugzilla bug 1975711, which is invalid:

expected dependent Bugzilla bug 1972753 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-25T01:00:27Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-25T01:00:32Z

@openshift-bot: This pull request references Bugzilla bug 1975711, which is invalid:

expected dependent Bugzilla bug 1972753 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-26T01:00:45Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-26T01:00:50Z

@openshift-bot: This pull request references Bugzilla bug 1975711, which is invalid:

expected dependent Bugzilla bug 1972753 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-27T01:01:25Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-27T01:01:29Z

@openshift-bot: This pull request references Bugzilla bug 1975711, which is invalid:

expected dependent Bugzilla bug 1972753 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-28T01:00:38Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-28T01:00:42Z

@openshift-bot: This pull request references Bugzilla bug 1975711, which is invalid:

expected dependent Bugzilla bug 1972753 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-29T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-29T01:01:12Z

@openshift-bot: This pull request references Bugzilla bug 1975711, which is invalid:

expected dependent Bugzilla bug 1972753 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-30T01:01:05Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-30T01:01:15Z

@openshift-bot: This pull request references Bugzilla bug 1975711, which is invalid:

expected dependent Bugzilla bug 1972753 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-31T01:01:09Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-31T01:01:13Z

@openshift-bot: This pull request references Bugzilla bug 1975711, which is invalid:

expected dependent Bugzilla bug 1972753 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-01T01:00:35Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-01T01:00:39Z

@openshift-bot: This pull request references Bugzilla bug 1975711, which is invalid:

expected dependent Bugzilla bug 1972753 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-02T01:00:47Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-02T01:00:53Z

@openshift-bot: This pull request references Bugzilla bug 1975711, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1972753 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1972753 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mfojtik · 2021-09-10T06:22:44Z

[patch-manager] 🚀 Approved for z-stream by score: 0.20

adding cherry-pick approved

openshift-ci · 2021-09-10T06:23:30Z

@derekhiggins: All pull requests linked via external trackers have merged:

openshift/cluster-baremetal-operator#166

Bugzilla bug 1975711 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 24, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 24, 2021

openshift-ci bot requested review from dhellmann and hardys June 24, 2021 09:31

sadasu approved these changes Jun 29, 2021

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2021

openshift-ci bot removed the request for review from dhellmann June 29, 2021 17:45

asalkeld reviewed Jun 30, 2021

View reviewed changes

openshift-ci bot assigned asalkeld Jun 30, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 30, 2021

asalkeld reviewed Jul 2, 2021

View reviewed changes

openshift-ci bot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 22, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 2, 2021

mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 10, 2021

openshift-merge-robot merged commit 72d1bb1 into openshift:release-4.8 Sep 10, 2021

Bug 1975711: Only start static ip set if provisioning net not disabled #166

Bug 1975711: Only start static ip set if provisioning net not disabled #166

Conversation

derekhiggins commented Jun 24, 2021

openshift-ci bot commented Jun 24, 2021

sadasu commented Jun 29, 2021

openshift-ci bot commented Jun 29, 2021

dhellmann commented Jun 29, 2021

asalkeld left a comment

Choose a reason for hiding this comment

asalkeld commented Jun 30, 2021

openshift-ci bot commented Jun 30, 2021

openshift-bot commented Jun 30, 2021

openshift-bot commented Jun 30, 2021

openshift-bot commented Jun 30, 2021

openshift-bot commented Jun 30, 2021

openshift-bot commented Jun 30, 2021

openshift-bot commented Jul 1, 2021

openshift-bot commented Jul 1, 2021

asalkeld left a comment

Choose a reason for hiding this comment

sdodson commented Jul 22, 2021

openshift-ci bot commented Jul 22, 2021

openshift-bot commented Aug 22, 2021

openshift-ci bot commented Aug 22, 2021

openshift-bot commented Aug 23, 2021

openshift-ci bot commented Aug 23, 2021

openshift-bot commented Aug 24, 2021

openshift-ci bot commented Aug 24, 2021

openshift-bot commented Aug 25, 2021

openshift-ci bot commented Aug 25, 2021

openshift-bot commented Aug 26, 2021

openshift-ci bot commented Aug 26, 2021

openshift-bot commented Aug 27, 2021

openshift-ci bot commented Aug 27, 2021

openshift-bot commented Aug 28, 2021

openshift-ci bot commented Aug 28, 2021

openshift-bot commented Aug 29, 2021

openshift-ci bot commented Aug 29, 2021

openshift-bot commented Aug 30, 2021

openshift-ci bot commented Aug 30, 2021

openshift-bot commented Aug 31, 2021

openshift-ci bot commented Aug 31, 2021

openshift-bot commented Sep 1, 2021

openshift-ci bot commented Sep 1, 2021

openshift-bot commented Sep 2, 2021

openshift-ci bot commented Sep 2, 2021

mfojtik commented Sep 10, 2021

openshift-ci bot commented Sep 10, 2021