Bug 1973724: reorder the initContainers, so that static-ip-set happens prior to the image download

[asalkeld]

/cc @zaneb

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asalkeld

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [asalkeld]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@asalkeld: This pull request references Bugzilla bug 1973724, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

Bug 1973724: reorder the initContainers, so that static-ip-set happens prior to the image download

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zaneb]

The only concern with doing this was that @hardys mentioned there is a 5-minute timeout after which the provisioning VIP will fail over if we haven't finished downloading the image and started the pod. Per Steve's comment there though, it should be fair to assume that 5 minutes is enough.

Theoretically, because the images are now stored in the host filesystem, it should be possible to run this init container outside of the Pod. However, knowing when we need to re-run it (when the image changes? when an image-cache pod fails?) is challenging.

/lgtm
/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[asalkeld]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@asalkeld: All pull requests linked via external trackers have merged:

• openshift/cluster-baremetal-operator#169

Bugzilla bug 1973724 has been moved to the MODIFIED state.

In response to this:

Bug 1973724: reorder the initContainers, so that static-ip-set happens prior to the image download

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.