Pass IRONIC_EXTERNAL_IP to Ironic container #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If VirtualMediaViaExternalNetwork is set and the ProvisioningNetwork is not Disabled, remote workers on the external network need to use the host IP of the master node on the external network to talk back to Ironic.
openshift-ci
bot
added
the
approved
|
/retest |
|
/test e2e-metal-ipi |
1 similar comment
|
/test e2e-metal-ipi |
|
/retest |
|
Current e2e-metal-ipi failures should be taken care of by openshift/machine-config-operator#2650. |
|
/retest |
|
LGTM! I've tested this change now and it works as advertised. Be great to get this in soon. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kirankt, sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If VirtualMediaViaExternalNetwork is set and the ProvisioningNetwork
is not Disabled, remote workers on the external network need to use
the host IP of the master node on the external network to talk back to
Ironic.