Bug 1986462: Separate the names of machine os downloader when two copies are started #185
Conversation
…ges are downloaded in addition to qcow2
openshift-ci
bot
added
bugzilla/severity-medium
|
@kirankt: This pull request references Bugzilla bug 1986462, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kirankt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-metal-ipi |
There was a problem hiding this comment.
can you create a new unit test section like this https://github.com/openshift/cluster-baremetal-operator/blob/master/provisioning/baremetal_pod_test.go#L330-L346
but with the PreProvisioningOSDownloadURLs defined
This PR only deals with the initContainers. We don't really mess with the existing containers in the pod. But I will add a section in the initContainers. Realistically there should be another PR that should validate the preProvisioningOSDownloadURLs and perform unit testing on them. |
|
/test e2e-agnostic |
|
/test e2e-metal-ipi-ovn-ipv6 |
1 similar comment
|
/test e2e-metal-ipi-ovn-ipv6 |
|
@kirankt: All pull requests linked via external trackers have merged: Bugzilla bug 1986462 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When specifying both PreProvisioningOSDownloadURLs and ProvisioningOSDownloadURL in the provisioning config CR, CBO will fail to reconcile becasuse two copies of machine-os-downloader init containers with the same name are started. The names of these initcontainers should be different when both of them are spawned together.