OCPBUGS-27145: Reduce container privileges #396
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Tests are failing because the fix for https://bugzilla.redhat.com/show_bug.cgi?id=1908302 in metal3-static-ip-manager - toggling the addr_gen mode - requires extra capabilities. |
zaneb
force-pushed
the
container-privilege
branch
from
9a83f44
to
74967f0
Compare
|
/rename OCPBUGS-27145: Reduce container privileges |
zaneb
changed the title
openshift-ci-robot
added
jira/severity-low
|
@zaneb: This pull request references Jira Issue OCPBUGS-27145, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@zaneb: This pull request references Jira Issue OCPBUGS-27145, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
zaneb
force-pushed
the
container-privilege
branch
from
74967f0
to
1a9513a
Compare
Many of the containers we run have to be run in privileged mode in order to access a hostPath volume - not only so they can write files as root, but also to get an SELinux context that allows it. However, some containers currently running as privileged do not require this. Disabled privileged mode and add only the required capabilities for these containers.
zaneb
force-pushed
the
container-privilege
branch
from
1a9513a
to
5ad7dbb
Compare
|
/retest |
|
Metal upgrade jobs were permafailing prior to this by the looks of it. |
|
/cc @dtantsur |
|
/lgtm |
|
@zaneb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-metal-ipi-sdn-serial-ipv4 |
openshift-merge-bot
bot
merged commit 345b62a
into
openshift:master
|
@zaneb: Jira Issue OCPBUGS-27145: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-27145 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-baremetal-operator-container-v4.16.0-202402011710.p0.g345b62a.assembly.stream for distgit ose-cluster-baremetal-operator. |
|
Fix included in accepted release 4.16.0-0.nightly-2024-02-02-002725 |
|
Fix included in accepted release 4.16.0-0.nightly-2024-05-08-222442 |
Many of the containers we run have to be run in privileged mode in order to access a host volume - not only so they can write files as root, but also to get an SELinux context that allows it.
However, some containers currently running as privileged do not require this.