Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METAL-979: Add RBAC for newer CRDs hostfirmwarecomponents and dataimages #412

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

iurygregory
Copy link
Contributor

This commit includes the RBACs for the following resources:

This commit includes the RBACs for the following resources:
- metal3.io/hostfirmwarecomponents + /status + /finalizers
- metal3.io/dataimages + /status + /finalizers
  (The controller is not yet merged upstream or downstream)
@iurygregory iurygregory changed the title Add RBAC for newer CRDs hostfirmwarecomponents and dataimages METAL-979: Add RBAC for newer CRDs hostfirmwarecomponents and dataimages Apr 16, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 16, 2024

@iurygregory: This pull request references METAL-979 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This commit includes the RBACs for the following resources:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dtantsur
Copy link
Member

/approve

@openshift-ci openshift-ci bot requested review from elfosardo and honza April 16, 2024 13:12
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@honza
Copy link
Member

honza commented Apr 16, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f908020 and 2 for PR HEAD c9362b4 in total

@iurygregory
Copy link
Contributor Author

/test e2e-metal-ipi-upgrade
/test e2e-metal-ipi-upgrade-ovn-ipv6
/test e2e-metal-ipi-ovn-dualstack

@iurygregory
Copy link
Contributor Author

/test e2e-metal-ipi-serial-ipv4

@iurygregory
Copy link
Contributor Author

/test e2e-metal-ipi-upgrade-ovn-ipv6

@iurygregory
Copy link
Contributor Author

/test e2e-metal-ipi-upgrade

@openshift-merge-bot openshift-merge-bot bot merged commit fe323a0 into openshift:master Apr 17, 2024
15 of 17 checks passed
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

@iurygregory: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-upgrade-ovn-ipv6 c9362b4 link false /test e2e-metal-ipi-upgrade-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-baremetal-operator-container-v4.16.0-202404162215.p0.gfe323a0.assembly.stream.el9 for distgit ose-cluster-baremetal-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants