OCPBUGS-29660: Ignore provisioning ip config if disabled

[derekhiggins]

getProvisioningIPCIDR now returns nil if ProvisioningNetwork is disabled. The external HostIP will then be used (as intended when the prov network is disabled).

[openshift-ci-robot]

@derekhiggins: This pull request references Jira Issue OCPBUGS-29660, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

getProvisioningIPCIDR now returns nil if ProvisioningNetwork is disabled. The external HostIP will then be used (as intended when the prov network is disabled).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[derekhiggins]

/jira refresh

[openshift-ci-robot]

@derekhiggins: This pull request references Jira Issue OCPBUGS-29660, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jadhaj

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[honza]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [honza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[derekhiggins]

/retest-required

[derekhiggins]

/test e2e-metal-ipi-ovn-virtualmedia

[derekhiggins]

Just want to double check this, the PR will mean we ignore any provisioning IP when the prov network is disabled,
and instead the Host IP is used.

Is this the correct behaviour? Could the user be potentially be providing a Provisioning IP from this situation mentioned in the readme?

when the provisioning network is fully disabled. User can bring up the baremetal cluster using virtual media or assisted installation. If using metal3 for power management, BMCs must be accessible from the machine networks. User should provide two IPs on the external network that would be used for provisioning services.

[derekhiggins]

/retest-required

[openshift-ci]

@derekhiggins: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-upgrade	d6299b7	link	false	/test e2e-metal-ipi-upgrade
ci/prow/e2e-metal-ipi-upgrade-ovn-ipv6	d6299b7	link	false	/test e2e-metal-ipi-upgrade-ovn-ipv6
ci/prow/e2e-metal-ipi-ovn-dualstack	d6299b7	link	false	/test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[derekhiggins]

/hold
waiting on clarification that this is ok to merge

[zaneb]

This seems as plausible as anything.

[derekhiggins]

thanks, unholding
/unhold