move logic for managing disabled state back inside the reconciler #69
Conversation
openshift-ci-robot
added
the
approved
Avoid duplicating the logic for handling the disabled state by moving the call to initialize the ClusterOperator from main into SetupWithManager. That also lets us reuse the existing reconciler method to set the ClusterOperator status, so we can eliminate SetCOInDisabledState entirely. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
dhellmann
force-pushed
the
misc-cleanup
branch
from
2961cb7
to
d247a5e
Compare
|
+1 for eliminating 2 separate ways to set the CO in Disabled state. Will let @asalkeld take a look also. |
|
e2e-agnostic failure not related to this change. /test e2e-agnostic |
|
/test e2e-agnostic |
|
/retest |
|
/test e2e-agnostic |
3 similar comments
|
/test e2e-agnostic |
|
/test e2e-agnostic |
|
/test e2e-agnostic |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-agnostic |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
19 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
We are well past the point where CBO is relevant for e2e-agnostic. I'm comfortable overriding this for now, but let's make sure we're looking at the CI logs before we do that on any others. /override ci/prow/e2e-agnostic |
|
@stbenjam: Cannot update PR status for context ci/prow/e2e-agnostic In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-agnostic In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Avoid duplicating the logic for handling the disabled state by moving
the call to initialize the ClusterOperator from main into
SetupWithManager. That also lets us reuse the existing reconciler
method to set the ClusterOperator status, so we can eliminate
SetCOInDisabledState entirely.
This is a follow-up to #63
/cc @sadasu @asalkeld