pkg/start: Prune public API #10
Conversation
Lowercase labels that are not used outside of this package to make it
easier to discover the intended public API for the package. After
this commit:
$ godoc ./pkg/start/
PACKAGE DOCUMENTATION
package start
import "./pkg/start/"
FUNCTIONS
func NewStartCommand(config Config) (*startCommand, error)
func UserOutput(format string, a ...interface{})
All start command printing to stdout should go through this fmt.Printf
wrapper. The stdout of the start command should convey information
useful to a human sitting at a terminal watching their cluster bootstrap
itself. Otherwise the message should go to stderr.
TYPES
type Config struct {
AssetDir string
PodManifestPath string
Strict bool
RequiredPods []string
}
openshift-ci-robot
added
the
size/M
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Dunno about that. /retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Lowercase labels that are not used outside of this package to make it easier to discover the intended public API for the package. After this pull-request: