Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1855628: bump golang.com/x/text and switch to go-mod and build-machinery #37

Merged
merged 10 commits into from Jan 15, 2021
Merged

Bug 1855628: bump golang.com/x/text and switch to go-mod and build-machinery #37

merged 10 commits into from Jan 15, 2021

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jul 24, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jul 24, 2020
@openshift-ci-robot
Copy link

@sttts: This pull request references Bugzilla bug 1855628, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1855628: bump golang.com/x/text and switch to go-mod and build-machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 24, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@sttts
Copy link
Contributor Author

sttts commented Aug 21, 2020

/retest

@sttts sttts force-pushed the sttts-bump-golang-x-text branch 2 times, most recently from 7549589 to 7c47829 Compare August 25, 2020 08:41
@sttts sttts mentioned this pull request Aug 26, 2020
Merged
@sttts
Copy link
Contributor Author

sttts commented Aug 26, 2020

/retest

3 similar comments
@sttts
Copy link
Contributor Author

sttts commented Aug 26, 2020

/retest

@sttts
Copy link
Contributor Author

sttts commented Aug 27, 2020

/retest

@sttts
Copy link
Contributor Author

sttts commented Aug 27, 2020

/retest

@mfojtik
Copy link
Member

mfojtik commented Aug 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sttts
Copy link
Contributor Author

sttts commented Aug 31, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2020 •
edited

@sttts: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade ec56669 link /test e2e-aws-upgrade
ci/prow/e2e-aws c0d74fb link /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts
Copy link
Contributor Author

sttts commented Oct 27, 2020

/retest

@openshift-merge-robot
Copy link
Contributor

@sttts: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws c0d74fb link /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts
Copy link
Contributor Author

sttts commented Nov 24, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2020
@eranco74
Copy link
Contributor

eranco74 commented Jan 4, 2021

/retest

@eranco74 eranco74 mentioned this pull request Jan 5, 2021
Closed
@eranco74
Copy link
Contributor

eranco74 commented Jan 5, 2021

@sttts I took a look at this failure.
test failed due to:
Bootstrap failed to complete: failed to wait for bootstrapping to complete: timed out waiting for the condition
But clusterversion and clusteroperators look good:
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-bootstrap/37/pull-ci-openshift-cluster-bootstrap-master-e2e-aws/1346093711796211712/artifacts/e2e-aws/gather-extra/oc_cmds/clusterversion

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-bootstrap/37/pull-ci-openshift-cluster-bootstrap-master-e2e-aws/1346093711796211712/artifacts/e2e-aws/gather-extra/oc_cmds/clusteroperators

I can't seem to find the bootstrap config map the installer is waiting for
NewListWatchFromClient(client.CoreV1().RESTClient(), "configmaps", "kube-system", fields.OneTermEqualSelector("metadata.name", "bootstrap"))
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-bootstrap/37/pull-ci-openshift-cluster-bootstrap-master-e2e-aws/1346093711796211712/artifacts/e2e-aws/gather-extra/configmaps.json

any idea where I can find the installer log-bundle-20210104144437.tar.gz?

@eranco74 eranco74 mentioned this pull request Jan 6, 2021
Merged
@eranco74
Copy link
Contributor

eranco74 commented Jan 7, 2021

Found the issue:
Jan 07 08:44:28 ip-10-0-60-145 bootkube.sh[51405]: All self-hosted control plane components successfully started Jan 07 08:44:29 ip-10-0-60-145 bootkube.sh[51405]: I0107 08:44:29.951471 1 request.go:645] Throttling request took 1.126832486s, request: GET:https://localhost:6443/apis/route.openshift.io/v1?timeout=32s Jan 07 08:44:36 ip-10-0-60-145 bootkube.sh[51405]: [#1] context canceled Jan 07 08:44:36 ip-10-0-60-145 bootkube.sh[51405]: Sending bootstrap-success event.Tearing down temporary bootstrap control plane... Jan 07 08:44:36 ip-10-0-60-145 bootkube.sh[51405]: Error: context canceled
It's trying to send the bootstrap-success event with a canceled context.
Fixed here - 0af00c8

@eranco74
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link

@eranco74: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor Author

sttts commented Jan 11, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2021
@eranco74
Copy link
Contributor

/retest

@sttts
Copy link
Contributor Author

sttts commented Jan 13, 2021

/retest

Infra?

@eranco74
Copy link
Contributor

/test e2e-aws

@marun
Copy link

marun commented Jan 15, 2021

/lgtm

@openshift-ci-robot
Copy link

@marun: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Jan 15, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, marun, mfojtik, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6665cae into openshift:master Jan 15, 2021
@openshift-ci-robot
Copy link

@sttts: All pull requests linked via external trackers have merged:

Bugzilla bug 1855628 has been moved to the MODIFIED state.

In response to this:

Bug 1855628: bump golang.com/x/text and switch to go-mod and build-machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sttts @openshift-ci-robot @mfojtik @openshift-bot @openshift-merge-robot @eranco74 @marun