Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 2006945: extend hardcoded restmapper for cluster-bootstrap to avoid crashlooping bootstrap kube-apiserver #64

Merged
merged 1 commit into from Sep 23, 2021

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 22, 2021

updates hardcoded restmapper

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021
@dgoodwin
Copy link

Possibly related to https://bugzilla.redhat.com/show_bug.cgi?id=2005967

@dgoodwin
Copy link

Bug filed for this specific issue: https://bugzilla.redhat.com/show_bug.cgi?id=2006945

@deads2k deads2k changed the title extend hardcoded restmapper for cluster-bootstrap to avoid crashlooping bootstrap kube-apiserver bug 2006945: extend hardcoded restmapper for cluster-bootstrap to avoid crashlooping bootstrap kube-apiserver Sep 22, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

@deads2k: This pull request references Bugzilla bug 2006945, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

bug 2006945: extend hardcoded restmapper for cluster-bootstrap to avoid crashlooping bootstrap kube-apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 22, 2021
@deads2k
Copy link
Contributor Author

deads2k commented Sep 22, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

@deads2k: This pull request references Bugzilla bug 2006945, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gpei@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2021

@deads2k: This pull request references Bugzilla bug 2006945, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yunjiang@redhat.com), skipping review request.

In response to this:

bug 2006945: extend hardcoded restmapper for cluster-bootstrap to avoid crashlooping bootstrap kube-apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 23, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2021
@sttts
Copy link
Contributor

sttts commented Sep 23, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2021

@deads2k: All pull requests linked via external trackers have merged:

Bugzilla bug 2006945 has been moved to the MODIFIED state.

In response to this:

bug 2006945: extend hardcoded restmapper for cluster-bootstrap to avoid crashlooping bootstrap kube-apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 23, 2021

/cherrypick release-4.9

@openshift-cherrypick-robot

@deads2k: #64 failed to apply on top of branch "release-4.9":

Applying: update library-go to get new hardcoded restmapper entries
.git/rebase-apply/patch:7434: trailing whitespace.
We track the log output from the makefile tests to make sure any change is visible and can be audited. Unfortunately due to subtle linux tooling differences in distributions and versions, `make update` may not get you the exact output as the CI. To avoid it, just run the command in the same container as CI:   
.git/rebase-apply/patch:9834: trailing whitespace.
search    show     status  
.git/rebase-apply/patch:12772: trailing whitespace.
	
.git/rebase-apply/patch:98190: new blank line at EOF.
+
.git/rebase-apply/patch:99273: new blank line at EOF.
+
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	go.sum
Falling back to patching base and 3-way merge...
Removing vendor/k8s.io/client-go/pkg/version/def.bzl
Removing vendor/k8s.io/api/batch/v2alpha1/types_swagger_doc_generated.go
Removing vendor/k8s.io/api/batch/v2alpha1/types.go
Removing vendor/k8s.io/api/batch/v2alpha1/generated.proto
Removing vendor/gopkg.in/yaml.v3/.travis.yml
Removing vendor/google.golang.org/protobuf/internal/mapsort/mapsort.go
Removing vendor/google.golang.org/protobuf/internal/fieldsort/fieldsort.go
Removing vendor/golang.org/x/sys/unix/ztypes_darwin_arm.go
Removing vendor/golang.org/x/sys/unix/ztypes_darwin_386.go
Removing vendor/golang.org/x/sys/unix/zsysnum_darwin_arm.go
Removing vendor/golang.org/x/sys/unix/zsysnum_darwin_386.go
Removing vendor/golang.org/x/sys/unix/zsyscall_darwin_arm.s
Removing vendor/golang.org/x/sys/unix/zsyscall_darwin_arm.go
Removing vendor/golang.org/x/sys/unix/zsyscall_darwin_arm.1_13.s
Removing vendor/golang.org/x/sys/unix/zsyscall_darwin_arm.1_13.go
Removing vendor/golang.org/x/sys/unix/zsyscall_darwin_386.s
Removing vendor/golang.org/x/sys/unix/zsyscall_darwin_386.go
Removing vendor/golang.org/x/sys/unix/zsyscall_darwin_386.1_13.s
Removing vendor/golang.org/x/sys/unix/zsyscall_darwin_386.1_13.go
Removing vendor/golang.org/x/sys/unix/zerrors_darwin_arm.go
Removing vendor/golang.org/x/sys/unix/zerrors_darwin_386.go
Removing vendor/golang.org/x/sys/unix/syscall_darwin_arm.go
Removing vendor/golang.org/x/sys/unix/syscall_darwin_386.go
Removing vendor/golang.org/x/sys/unix/asm_openbsd_arm64.s
Removing vendor/golang.org/x/sys/unix/asm_openbsd_arm.s
Removing vendor/golang.org/x/sys/unix/asm_netbsd_arm64.s
Removing vendor/golang.org/x/sys/unix/asm_netbsd_arm.s
Removing vendor/golang.org/x/sys/unix/asm_freebsd_arm64.s
Removing vendor/golang.org/x/sys/unix/asm_freebsd_arm.s
Removing vendor/golang.org/x/sys/unix/asm_freebsd_amd64.s
Removing vendor/golang.org/x/sys/unix/asm_darwin_arm64.s
Removing vendor/golang.org/x/sys/unix/asm_darwin_amd64.s
Removing vendor/golang.org/x/sys/unix/asm_darwin_386.s
Removing vendor/github.com/hashicorp/golang-lru/simplelru/lru_interface.go
Removing vendor/github.com/hashicorp/golang-lru/simplelru/lru.go
Removing vendor/github.com/hashicorp/golang-lru/lru.go
Removing vendor/github.com/hashicorp/golang-lru/go.mod
Removing vendor/github.com/hashicorp/golang-lru/doc.go
Removing vendor/github.com/hashicorp/golang-lru/arc.go
Removing vendor/github.com/hashicorp/golang-lru/README.md
Removing vendor/github.com/hashicorp/golang-lru/LICENSE
Removing vendor/github.com/hashicorp/golang-lru/2q.go
Removing vendor/github.com/hashicorp/golang-lru/.gitignore
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 update library-go to get new hardcoded restmapper entries
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-bootstrap-container-v4.10.0-202305011254.p0.gf22d1c6.assembly.stream for distgit ose-cluster-bootstrap.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-bootstrap-container-v4.12.0-202305022015.p0.gf22d1c6.assembly.stream for distgit ose-cluster-bootstrap.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants