OCPCLOUD-1726, OCPBUGS-25654: GCP Credential Req. manifest for CAPI to use new API field

[odvarkadaniel]

This PR removes all the predefinedRoles which give elevated permissions. We get those permissions and put them into the new API field Permissions []string. These permissions are known to thanks to the command gcloud iam roles describe <role> - this lists all the included permissions we want.

[JoelSpeed]

this lists all the included permissions we want.

Have you confirmed that this list is minimal? It's a very long list so i'd like to make sure that we do actually require each and every permission in the list. If you have, how did you do so?

[elmiko]

i'm curious if these permissions should look similar to the machine api related PR ?

[odvarkadaniel]

i'm curious if these permissions should look similar to the machine api related PR ?

Yes, some of the permission are the same, but CAPI has more defined services in its interface here: https://github.com/openshift/cluster-api-provider-gcp/tree/master/cloud/services/compute

Keep in mind that this is not yet tested and the e2e-gcp test job is not passing, even though I think that it might not be this change that is causing it. If you see any permission that are in your opinion extra, please let me know and I will respond why they are present in the list of permissions.

[abutcher]

We're leaking these custom roles created by CCO in CI so holding until we're cleaning them up.
/hold

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

/retest

[openshift-ci-robot]

@odvarkadaniel: This pull request references OCPCLOUD-1726 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR removes all the predefinedRoles which give elevated permissions. We get those permissions and put them into the new API field Permissions []string. These permissions are known to thanks to the command gcloud iam roles describe <role> - this lists all the included permissions we want.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jstuever]

/retest

[JoelSpeed]

/hold cancel

/lgtm
/approve

/test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD be94864 and 2 for PR HEAD c076b3a in total

[openshift-ci]

@odvarkadaniel: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-capi-operator-container-v4.16.0-202401051832.p0.gbf4db4b.assembly.stream for distgit ose-cluster-capi-operator.
All builds following this will include this PR.

[openshift-ci-robot]

@odvarkadaniel: Jira Issue OCPBUGS-25654: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25654 has been moved to the MODIFIED state.

In response to this:

This PR removes all the predefinedRoles which give elevated permissions. We get those permissions and put them into the new API field Permissions []string. These permissions are known to thanks to the command gcloud iam roles describe <role> - this lists all the included permissions we want.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@JoelSpeed: new pull request created: #155

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.