Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-7884: Restart pods if related configuration was changed #228

Merged
merged 3 commits into from Mar 6, 2023
Merged

[release-4.12] OCPBUGS-7884: Restart pods if related configuration was changed #228

merged 3 commits into from Mar 6, 2023

Conversation

lobziik
Copy link
Contributor

@lobziik lobziik commented Feb 22, 2023

Manual cherry pick from #227

This PR does not contain commits which is not needed for OCP 4.12 or ain't entirely related to the bugfix.

@lobziik
Augment Deployments and Daemonsets with related configs hashes
41a351a 
To ensure that operands are using most recent configurations,
such as cloud configs or credentials, check for related config content
was added.

This patch introduces hash calculation for secrets and configmaps content
if they are detected in deployment/daemonset pod template spec.

(cherry picked from commit 8ec1840)
@lobziik
Add watch for secrets and configmaps in `openshift-cloud-controller-m…
bbe6514 
…anager` namespace

(cherry picked from commit 5b275f1)
@lobziik
Aling events reason with the conventions
854fc11 
Replace all event reasons with constants instead of
using free-form strings to comply k8s conventions

Ref:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#events
(cherry picked from commit bc681b8)
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

@lobziik: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-7882: Restart pods if related configuration was changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 22, 2023
@openshift-ci-robot
Copy link

@lobziik: This pull request references Jira Issue OCPBUGS-7882, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-6063 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-6063 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @miyadav

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry pick from #227

This PR does not contain commits which is not needed for OCP 4.12 or ain't entirely related to the bugfix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from miyadav February 22, 2023 15:20
@lobziik
Copy link
Contributor Author

lobziik commented Feb 22, 2023

/cc @elmiko @JoelSpeed @pierreprinetti

elmiko
elmiko reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@JoelSpeed
Copy link
Contributor

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

@lobziik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn 854fc11 link false /test e2e-azure-ovn
ci/prow/e2e-gcp-ovn-ccm-install 854fc11 link false /test e2e-gcp-ovn-ccm-install
ci/prow/e2e-aws-ovn-ccm-install 854fc11 link false /test e2e-aws-ovn-ccm-install
ci/prow/e2e-gcp-ovn-ccm 854fc11 link false /test e2e-gcp-ovn-ccm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed JoelSpeed changed the title [release-4.12] OCPBUGS-7882: Restart pods if related configuration was changed [release-4.12] OCPBUGS-7884: Restart pods if related configuration was changed Feb 27, 2023
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 27, 2023
@openshift-ci-robot
Copy link

@lobziik: This pull request references Jira Issue OCPBUGS-7884, which is invalid:

  • expected dependent Jira Issue OCPBUGS-5036 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry pick from #227

This PR does not contain commits which is not needed for OCP 4.12 or ain't entirely related to the bugfix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2023

@lobziik: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

[release-4.12] OCPBUGS-7884: Restart pods if related configuration was changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lobziik
Copy link
Contributor Author

lobziik commented Mar 1, 2023

/jira refresh

@openshift-ci-robot
Copy link

@lobziik: This pull request references Jira Issue OCPBUGS-7884, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lobziik
Copy link
Contributor Author

lobziik commented Mar 1, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 1, 2023
@openshift-ci-robot
Copy link

@lobziik: This pull request references Jira Issue OCPBUGS-7884, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-5036 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-5036 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from eurijon March 1, 2023 15:21
@sunzhaohua2
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit efccbb3 into openshift:release-4.12 Mar 6, 2023
@openshift-ci-robot
Copy link

@lobziik: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7884 has been moved to the MODIFIED state.

In response to this:

Manual cherry pick from #227

This PR does not contain commits which is not needed for OCP 4.12 or ain't entirely related to the bugfix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER] (beta)

This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.12.0-202303061432.p0.gefccbb3.assembly.stream for distgit ose-cluster-cloud-controller-manager-operator.
All builds following this will include this PR.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@miyadav miyadav Awaiting requested review from miyadav

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

@eurijon eurijon Awaiting requested review from eurijon

Assignees

@elmiko elmiko

@jhou1 jhou1

@sunzhaohua2 sunzhaohua2

@miyadav miyadav

@huali9 huali9

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@lobziik @openshift-ci-robot @JoelSpeed @sunzhaohua2 @openshift-bot @elmiko @jhou1 @openshift-merge-robot @miyadav @huali9