OCPBUGS-23308: Set IPFamilyPriority and ExcludeNetworkSubnetCIDR for vSphere IPv6-only #299
Conversation
…vSphere IPv6-only In 428d639 we have added a support for correctly setting `IPFamilyPriority` and `ExcludeNetworkSubnetCIDR` when using dual-stack configuration. That commit however missed the configuration for IPv6-only setups and as a result those clusters are running with `IPv4` as a value of `IPFamilyPriority`. This PR changes the logic so that we now cover settings for both IPv6-only and dual-stack configurations. There is no need for explicit handling of IPv4-only clusters as those work correctly today. Fixes: OCPBUGS-23308 Relates-to: OCPBUGS-18641
openshift-ci-robot
added
jira/valid-reference
|
@mkowalski: This pull request references Jira Issue OCPBUGS-23308, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@mkowalski: This pull request references Jira Issue OCPBUGS-23308, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
openshift-ci
bot
requested review from
JoelSpeed,
rbbratta,
sunzhaohua2,
nrb and
racheljpg
|
/test e2e-vsphere-ovn |
|
@mkowalski: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
e2e-vsphere-ovn passed so there is no regression in IPv4 world. Other failed platforms do not use the modified code so their failures are not relevant |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 0ce73df
into
openshift:master
|
@mkowalski: Jira Issue OCPBUGS-23308: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-23308 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.15.0-202311272131.p0.g0ce73df.assembly.stream for distgit ose-cluster-cloud-controller-manager-operator. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-11-28-101923 |
In 428d639 we have added a support for correctly setting
IPFamilyPriorityandExcludeNetworkSubnetCIDRwhen using dual-stack configuration. That commit however missed the configuration for IPv6-only setups and as a result those clusters are running withIPv4as a value ofIPFamilyPriority.This PR changes the logic so that we now cover settings for both IPv6-only and dual-stack configurations. There is no need for explicit handling of IPv4-only clusters as those work correctly today.
Fixes: OCPBUGS-23308
Relates-to: OCPBUGS-18641