Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-1374: Revert #301 "OCPCLOUD-2278: Add kube-rbac-proxy container & ensure metrics are only available via HTTPS" #303

Merged

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Nov 29, 2023

Reverts #301 ; tracked by TRT-1374

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR appears to have broken hypershift jobs on CI payloads.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

The following should give per-merge signal that the fix is working: /payload-job periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn

CC: @racheljpg

PR created by Revertomatic™️

…ics"

This reverts commit 927ebcd, reversing
changes made to f403ed9.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2023

@dgoodwin: This pull request references TRT-1374 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #301 ; tracked by TRT-1374

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR appears to have broken hypershift jobs on CI payloads.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please unrevert this revert, layer a fix commit on top, and coordinate with hypershift team to see if there's a way to get reasonable pre-merge confidence before bringing back in. (maybe add a presubmit for hypershift is possible)

CC: @racheljpg

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2023

@dgoodwin: This pull request references TRT-1374 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #301 ; tracked by TRT-1374

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR appears to have broken hypershift jobs on CI payloads.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please unrevert this revert, layer a fix commit on top, and coordinate with hypershift team to see if there's a way to get reasonable pre-merge confidence before bringing back in. (maybe add a presubmit for hypershift is possible)

CC: @racheljpg

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dgoodwin
Copy link
Contributor Author

/payload-job periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn

Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

@dgoodwin: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/528f8520-8ee0-11ee-8742-f48fa208f226-0

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2023

@dgoodwin: This pull request references TRT-1374 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #301 ; tracked by TRT-1374

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR appears to have broken hypershift jobs on CI payloads.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

The following should give per-merge signal that the fix is working: /payload-job periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn

CC: @racheljpg

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bryan-cox
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@dgoodwin
Copy link
Contributor Author

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-alibaba-ovn
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-azure-ovn-upgrade
/override ci/prow/e2e-gcp-ovn-ccm
/override ci/prow/e2e-gcp-ovn-techpreview
/override ci/prow/e2e-openstack-ovn
/override ci/prow/e2e-vsphere-ovn

Overriding per TRT policy when we believe we're going back to a known good state.

Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-alibaba-ovn, ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-azure-ovn-upgrade, ci/prow/e2e-gcp-ovn-ccm, ci/prow/e2e-gcp-ovn-techpreview, ci/prow/e2e-openstack-ovn, ci/prow/e2e-vsphere-ovn

In response to this:

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-alibaba-ovn
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-azure-ovn-upgrade
/override ci/prow/e2e-gcp-ovn-ccm
/override ci/prow/e2e-gcp-ovn-techpreview
/override ci/prow/e2e-openstack-ovn
/override ci/prow/e2e-vsphere-ovn

Overriding per TRT policy when we believe we're going back to a known good state.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor Author

/override ci/prow/e2e-azure-ovn
/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-azure-ovn

In response to this:

/override ci/prow/e2e-azure-ovn
/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member

/label approved

@openshift-merge-bot openshift-merge-bot bot merged commit 70730ad into openshift:master Nov 29, 2023
16 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.15.0-202311292108.p0.g70730ad.assembly.stream for distgit ose-cluster-cloud-controller-manager-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants