New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-26494: PowerVS: handle 4.16 changes #322
OCPBUGS-26494: PowerVS: handle 4.16 changes #322
Conversation
hamzy
commented
Jan 10, 2024
•
edited
edited
- Change the --bind-address argument to 127.0.0.1
- Remove updating the pod IP address
@hamzy: This pull request references Jira Issue OCPBUGS-26494, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@hamzy: This pull request references Jira Issue OCPBUGS-26494, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @JoelSpeed @elmiko |
8463faf
to
0f0347b
Compare
@hamzy: This pull request references Jira Issue OCPBUGS-26494, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1) Change the --bind-address argument to 127.0.0.1 2) Remove updating the pod IP address
0f0347b
to
cf309f0
Compare
Change looks ok but I'd like to see an optional E2E job on the repo that proves this works |
I have hand edited a deploying cluster on the original changes and they worked for me. |
I will also add that we should eventually work to get that testing done. However, the PowerVS CI is not stable enough at the moment to require that testing before this PR merges. |
Not even stable enough to prove that a cluster can at least install? Given we know this prevents installs? |
Well it is more stable to get past the cluster installation step (I would guess > 80 or 90%). It is getting past running E2E testing where passing every test case consistently is problematic. |
I guess the optional passing requirement would at least not block other arches. |
What I'm interested in for the purpose of platforms like PowerVS is being able to check the CCM logs on CI runs and see if the CCM is doing what we expect it to do. Which I expect you can probably do with the current state of PowerVS CI |
@hamzy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c4db464
into
openshift:master
@hamzy: Jira Issue OCPBUGS-26494: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-26494 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.16.0-202401151732.p0.gc4db464.assembly.stream for distgit ose-cluster-cloud-controller-manager-operator. |
Fix included in accepted release 4.16.0-0.nightly-2024-01-18-111941 |