Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-26494: PowerVS: handle 4.16 changes #322

Merged
merged 1 commit into from Jan 15, 2024

Conversation

hamzy
Copy link
Contributor

@hamzy hamzy commented Jan 10, 2024

  1. Change the --bind-address argument to 127.0.0.1
  2. Remove updating the pod IP address

@openshift-ci openshift-ci bot requested review from nrb and racheljpg January 10, 2024 17:27
@hamzy hamzy changed the title PowerVS: handle 4.16 changes OCPBUGS-26494: PowerVS: handle 4.16 changes Jan 10, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 10, 2024
@openshift-ci-robot
Copy link

@hamzy: This pull request references Jira Issue OCPBUGS-26494, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  1. Remove the --bind-address argument
  2. Remove updating the pod IP address

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hamzy
Copy link
Contributor Author

hamzy commented Jan 10, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 10, 2024
@openshift-ci-robot
Copy link

@hamzy: This pull request references Jira Issue OCPBUGS-26494, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mjturek
Copy link

mjturek commented Jan 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mkumatag
Copy link
Member

/assign @JoelSpeed @elmiko

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024
@openshift-ci-robot
Copy link

@hamzy: This pull request references Jira Issue OCPBUGS-26494, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

  1. Change the --bind-address argument to 127.0.0.1
  2. Remove updating the pod IP address

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1) Change the --bind-address argument to 127.0.0.1
2) Remove updating the pod IP address
@JoelSpeed
Copy link
Contributor

Change looks ok but I'd like to see an optional E2E job on the repo that proves this works

@hamzy
Copy link
Contributor Author

hamzy commented Jan 12, 2024

Change looks ok but I'd like to see an optional E2E job on the repo that proves this works

I have hand edited a deploying cluster on the original changes and they worked for me.

@hamzy
Copy link
Contributor Author

hamzy commented Jan 12, 2024

I will also add that we should eventually work to get that testing done. However, the PowerVS CI is not stable enough at the moment to require that testing before this PR merges.

@JoelSpeed
Copy link
Contributor

I will also add that we should eventually work to get that testing done. However, the PowerVS CI is not stable enough at the moment to require that testing before this PR merges.

Not even stable enough to prove that a cluster can at least install? Given we know this prevents installs?

@hamzy
Copy link
Contributor Author

hamzy commented Jan 12, 2024

I will also add that we should eventually work to get that testing done. However, the PowerVS CI is not stable enough at the moment to require that testing before this PR merges.

Not even stable enough to prove that a cluster can at least install? Given we know this prevents installs?

Well it is more stable to get past the cluster installation step (I would guess > 80 or 90%). It is getting past running E2E testing where passing every test case consistently is problematic.

@hamzy
Copy link
Contributor Author

hamzy commented Jan 12, 2024

I guess the optional passing requirement would at least not block other arches.

@JoelSpeed
Copy link
Contributor

What I'm interested in for the purpose of platforms like PowerVS is being able to check the CCM logs on CI runs and see if the CCM is doing what we expect it to do. Which I expect you can probably do with the current state of PowerVS CI

Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

@hamzy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-upgrade cf309f0 link false /test e2e-gcp-ovn-upgrade
ci/prow/e2e-alibaba-ovn cf309f0 link false /test e2e-alibaba-ovn
ci/prow/e2e-vsphere-ovn cf309f0 link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c4db464 into openshift:master Jan 15, 2024
13 of 16 checks passed
@openshift-ci-robot
Copy link

@hamzy: Jira Issue OCPBUGS-26494: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26494 has been moved to the MODIFIED state.

In response to this:

  1. Change the --bind-address argument to 127.0.0.1
  2. Remove updating the pod IP address

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.16.0-202401151732.p0.gc4db464.assembly.stream for distgit ose-cluster-cloud-controller-manager-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-01-18-111941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants