OCPCLOUD-2424: Bump k8s packages to v1.29

[racheljpg]

Hello! This is a PR to bump the k8s packages to version 1.29. Thanks!

[openshift-ci-robot]

@racheljpg: This pull request references OCPCLOUD-2424 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Hello! This is a PR to bump the k8s packages to version 1.29. Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[nrb]

Looks like some imports and functions will need updating. From the CI failures:

cmd/azure-config-credentials-injector/main.go:150:3: printf: (k8s.io/klog/v2.Verbose).Info call has possible Printf formatting directive %s (govet)
		klog.V(4).Info("%s env variable is set, client secret authentication will be used", clientSecretEnvKey)
		^
pkg/config/config.go:90:3: printf: k8s.io/klog/v2.Errorf call needs 1 arg but has 2 args (govet)
		klog.Errorf("Unable to decode images file from location %s", imagesFile, err)
		^
pkg/controllers/resourceapply/resourceapply.go:157:3: printf: (k8s.io/klog/v2.Verbose).Infof does not support error-wrapping directive %w (govet)
		klog.V(3).Infof("Can not check related configs for %s/%s: %w", required.GetObjectKind(), required.GetName(), err)
		^
pkg/controllers/resourceapply/resourceapply.go:246:3: printf: (k8s.io/klog/v2.Verbose).Infof does not support error-wrapping directive %w (govet)
		klog.V(3).Infof("Can not check related configs for %s/%s: %w", required.GetObjectKind(), required.GetName(), err)
		^
cmd/config-sync-controllers/main.go:88:17: SA1019: klogr.New is deprecated: this uses a custom, out-dated output format. Use textlogger.NewLogger instead. (staticcheck)
	ctrl.SetLogger(klogr.New().WithName("CCCMOConfigSyncControllers"))
	               ^
pkg/cloud/common/substitution.go:8:2: SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
	"k8s.io/utils/pointer"
	^
pkg/cloud/common/substitution_test.go:10:2: SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
	"k8s.io/utils/pointer"
	^
pkg/controllers/suite_test.go:72:17: SA1019: klogr.New is deprecated: this uses a custom, out-dated output format. Use textlogger.NewLogger instead. (staticcheck)
	logf.SetLogger(klogr.New())
	               ^
pkg/controllers/cloud_config_sync_controller_test.go:15:2: SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
	"k8s.io/utils/pointer"
	^ 

[damdo]

/lgtm

Thanks!

[damdo]

This will need bumping

cluster-cloud-controller-manager-operator/Makefile

Line 6 in e1f0727

ENVTEST_K8S_VERSION = 1.28

[JoelSpeed]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment