Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1825944: kube_cloud_config: pass correct sourcekey to the transformers #128

Merged
merged 3 commits into from Apr 22, 2020
Merged

Bug 1825944: kube_cloud_config: pass correct sourcekey to the transformers #128

merged 3 commits into from Apr 22, 2020

Conversation

abhinavdahiya
Copy link
Contributor

/test e2e-gcp
/test e2e-azure

@openshift-ci-robot openshift-ci-robot added bugzilla/medium bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 21, 2020
@openshift-ci-robot
Copy link

@abhinavdahiya: This pull request references Bugzilla bug 1825944, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1825944: kube_cloud_config: pass correct sourcekey to the transformers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor Author

/hold

need to make sure gcp, azure work correctly.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2020
@abhinavdahiya
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2020
@abhinavdahiya
Copy link
Contributor Author

/bugzillla refresh

/test e2e-gcp
/test e2e-azure

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-config-operator/128/pull-ci-openshift-cluster-config-operator-master-e2e-azure/1/artifacts/e2e-azure/configmaps.json

        {
            "apiVersion": "v1",
            "data": {
                "cloud.conf": "{\n\t\"cloud\": \"AzurePublicCloud\",\n\t\"tenantId\": \"6047c7e9-b2ad-488d-a54e-dc3f6be6a7ee\",\n\t\"aadClientId\": \"\",\n\t\"aadClientSecret\": \"\",\n\t\"aadClientCertPath\": \"\",\n\t\"aadClientCertPassword\": \"\",\n\t\"useManagedIdentityExtension\": true,\n\t\"userAssignedIdentityID\": \"\",\n\t\"subscriptionId\": \"d38f1e38-4bed-438e-b227-833f997adf6a\",\n\t\"resourceGroup\": \"ci-op-s3j175fs-371be-mbn5k-rg\",\n\t\"location\": \"eastus2\",\n\t\"vnetName\": \"ci-op-s3j175fs-371be-mbn5k-vnet\",\n\t\"vnetResourceGroup\": \"ci-op-s3j175fs-371be-mbn5k-rg\",\n\t\"subnetName\": \"ci-op-s3j175fs-371be-mbn5k-worker-subnet\",\n\t\"securityGroupName\": \"ci-op-s3j175fs-371be-mbn5k-node-nsg\",\n\t\"routeTableName\": \"ci-op-s3j175fs-371be-mbn5k-node-routetable\",\n\t\"primaryAvailabilitySetName\": \"\",\n\t\"vmType\": \"\",\n\t\"primaryScaleSetName\": \"\",\n\t\"cloudProviderBackoff\": true,\n\t\"cloudProviderBackoffRetries\": 0,\n\t\"cloudProviderBackoffExponent\": 0,\n\t\"cloudProviderBackoffDuration\": 6,\n\t\"cloudProviderBackoffJitter\": 0,\n\t\"cloudProviderRateLimit\": true,\n\t\"cloudProviderRateLimitQPS\": 6,\n\t\"cloudProviderRateLimitBucket\": 10,\n\t\"cloudProviderRateLimitQPSWrite\": 6,\n\t\"cloudProviderRateLimitBucketWrite\": 10,\n\t\"useInstanceMetadata\": true,\n\t\"loadBalancerSku\": \"standard\",\n\t\"excludeMasterFromStandardLB\": null,\n\t\"disableOutboundSNAT\": null,\n\t\"maximumLoadBalancerRuleCount\": 0\n}\n"
            },
            "kind": "ConfigMap",
            "metadata": {
                "creationTimestamp": "2020-04-21T17:41:32Z",
                "managedFields": [
                    {
                        "apiVersion": "v1",
                        "fieldsType": "FieldsV1",
                        "fieldsV1": {
                            "f:data": {
                                ".": {},
                                "f:cloud.conf": {}
                            }
                        },
                        "manager": "cluster-config-operator",
                        "operation": "Update",
                        "time": "2020-04-21T17:41:32Z"
                    }
                ],
                "name": "kube-cloud-config",
                "namespace": "openshift-config-managed",
                "resourceVersion": "14588",
                "selfLink": "/api/v1/namespaces/openshift-config-managed/configmaps/kube-cloud-config",
                "uid": "92bb26b3-7cad-4b45-bbaa-c214fa5ad2c9"
            }
        },

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-config-operator/128/pull-ci-openshift-cluster-config-operator-master-e2e-gcp/1/artifacts/e2e-gcp/configmaps.json

        {
            "apiVersion": "v1",
            "data": {
                "cloud.conf": "[global]\nproject-id      = openshift-gce-devel-ci\nregional        = true\nmultizone       = true\nnode-tags       = ci-op-mjbwr-master\nnode-tags       = ci-op-mjbwr-worker\nnode-instance-prefix = ci-op-mjbwr\nexternal-instance-groups-prefix = ci-op-mjbwr\nsubnetwork-name = ci-op-mjbwr-worker-subnet\n\n"
            },
            "kind": "ConfigMap",
            "metadata": {
                "creationTimestamp": "2020-04-21T17:46:12Z",
                "managedFields": [
                    {
                        "apiVersion": "v1",
                        "fieldsType": "FieldsV1",
                        "fieldsV1": {
                            "f:data": {
                                ".": {},
                                "f:cloud.conf": {}
                            }
                        },
                        "manager": "cluster-config-operator",
                        "operation": "Update",
                        "time": "2020-04-21T17:46:12Z"
                    }
                ],
                "name": "kube-cloud-config",
                "namespace": "openshift-config-managed",
                "resourceVersion": "17524",
                "selfLink": "/api/v1/namespaces/openshift-config-managed/configmaps/kube-cloud-config",
                "uid": "d250e640-4957-4060-905d-94c2a510bf34"
            }
        },

@abhinavdahiya
Copy link
Contributor Author

/test e2e-gcp
/test e2e-azure

@abhinavdahiya
Copy link
Contributor Author

/bugzillla refresh

@sinnykumari
Copy link

/bugzillla refresh
/retest

@sinnykumari
Copy link

Using clusterbot checked-

@LorbusChris
Copy link
Member

/test e2e-azure

@deads2k
Copy link
Contributor

deads2k commented Apr 22, 2020

/lgtm

but you're still not quite green.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

@abhinavdahiya: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure ab3da4f link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LorbusChris
Copy link
Member

/test e2e-azure

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@abhinavdahiya
Copy link
Contributor Author

/bugzillla refresh

@hongkailiu
Copy link
Member

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 22, 2020
@openshift-ci-robot
Copy link

@hongkailiu: This pull request references Bugzilla bug 1825944, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 088dc50 into openshift:master Apr 22, 2020
@openshift-ci-robot
Copy link

@abhinavdahiya: All pull requests linked via external trackers have merged: openshift/cluster-config-operator#126, openshift/cluster-config-operator#128. Bugzilla bug 1825944 has been moved to the MODIFIED state.

In response to this:

Bug 1825944: kube_cloud_config: pass correct sourcekey to the transformers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@abhinavdahiya @openshift-ci-robot @sinnykumari @LorbusChris @deads2k @openshift-bot @hongkailiu @openshift-merge-robot