Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1850681: aws_platform_service_location: resync when user unsets the service endpoints in spec #143

Merged
merged 1 commit into from Jul 23, 2020
Merged

Bug 1850681: aws_platform_service_location: resync when user unsets the service endpoints in spec #143

merged 1 commit into from Jul 23, 2020

Conversation

abhinavdahiya
Copy link
Contributor

Previously when the user would reset the service endpoints in the spec, the controller would exit early as no work needed to be done.
That means it would leave the status set with previous service endpoints.

Now the controller resets the service endpoints when the user set the service endpoints to empty.

@abhinavdahiya
aws_platform_service_location: resync when user unsets the service en…
5d5e448 
…dpoints in spec

Previously when the user would reset the service endpoints in the spec, the controller would exit early as no work needed to be done.
That means it would leave the status set with previous service endpoints.

Now the controller resets the service endpoints when the user set the service endpoints to empty.
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 15, 2020
@openshift-ci-robot
Copy link

@abhinavdahiya: This pull request references Bugzilla bug 1850681, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1850681: aws_platform_service_location: resync when user unsets the service endpoints in spec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor Author

/assign @deads2k

@jhixson74
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@sttts
Copy link
Contributor

sttts commented Jul 23, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jhixson74, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit c878bbf into openshift:master Jul 23, 2020
@openshift-ci-robot
Copy link

@abhinavdahiya: All pull requests linked via external trackers have merged: openshift/cluster-config-operator#143. Bugzilla bug 1850681 has been moved to the MODIFIED state.

In response to this:

Bug 1850681: aws_platform_service_location: resync when user unsets the service endpoints in spec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sgreene570 sgreene570 mentioned this pull request Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@jhixson74 jhixson74

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@abhinavdahiya @openshift-ci-robot @jhixson74 @sttts @deads2k @openshift-merge-robot