Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AzureStack support #186

Merged
merged 2 commits into from Jun 22, 2021
Merged

Add AzureStack support #186

merged 2 commits into from Jun 22, 2021

Conversation

patrickdillon
Copy link
Contributor

Adds AzureStack as a valid cloud environment.

Depends on openshift/api#860

WIP as currently using personal branch.

cc @staebler
cc @jhixson74

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2021
@patrickdillon
Copy link
Contributor Author

/test images

@patrickdillon
Copy link
Contributor Author

/retest

@patrickdillon
Copy link
Contributor Author

/test images

2 similar comments
@patrickdillon
Copy link
Contributor Author

/test images

@patrickdillon
Copy link
Contributor Author

/test images

staebler
staebler reviewed Mar 16, 2021
View reviewed changes
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me once the api PR merges.

@patrickdillon
Copy link
Contributor Author

/test images

7 similar comments
@patrickdillon
Copy link
Contributor Author

/test images

@patrickdillon
Copy link
Contributor Author

/test images

@patrickdillon
Copy link
Contributor Author

/test images

@patrickdillon
Copy link
Contributor Author

/test images

@patrickdillon
Copy link
Contributor Author

/test images

@patrickdillon
Copy link
Contributor Author

/test images

@patrickdillon
Copy link
Contributor Author

/test images

@patrickdillon
Copy link
Contributor Author

/reopen

not sure why this closed

@openshift-ci-robot
Copy link

@patrickdillon: Failed to re-open PR: state cannot be changed. There are no new commits on the patrickdillon:azurestack branch.

In response to this:

/reopen

not sure why this closed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon patrickdillon mentioned this pull request Apr 5, 2021
Closed
@patrickdillon
Copy link
Contributor Author

/reopen

@openshift-ci-robot
Copy link

@patrickdillon: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon
To complete the pull request process, please assign soltysh after the PR has been reviewed.
You can assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon
To complete the pull request process, please assign soltysh after the PR has been reviewed.
You can assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon
Copy link
Contributor Author

/retest

@patrickdillon
Copy link
Contributor Author

/test images

@patrickdillon patrickdillon force-pushed the azurestack branch 2 times, most recently from 5ab1e15 to 1533eb3 Compare April 20, 2021 12:04
@patrickdillon
Copy link
Contributor Author

/test images

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2021
@patrickdillon patrickdillon force-pushed the azurestack branch 3 times, most recently from 9f9c78d to e977335 Compare June 10, 2021 13:36
@patrickdillon
Add Azure Stack as valid cloud
404df36 
Updates Azure to accept AzureStackCloud as a valid environment.
@patrickdillon patrickdillon changed the title WIP Add AzureStack support Add AzureStack support Jun 17, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2021
@patrickdillon
Copy link
Contributor Author

revendored now that API has merged

@deads2k PTAL for approve and LGTM

Will need follow up work in a separate PR to keep endpoints configmap in sync with API infra object

@sttts
Copy link
Contributor

sttts commented Jun 21, 2021

/lgtm
/approve
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 87bbc1c into openshift:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staebler staebler staebler left review comments

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@patrickdillon @openshift-ci-robot @sttts @openshift-bot @staebler @openshift-merge-robot