Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1984635: use new default leader election values to handle SNO environments #213

Merged
merged 3 commits into from Jul 29, 2021
Merged

Bug 1984635: use new default leader election values to handle SNO environments #213

merged 3 commits into from Jul 29, 2021

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Jul 28, 2021

It also removes klog v1 dependency.

I wrongly updated openshift-api instead of library-go in previous PR

#211

Antonio Ojea added 2 commits July 28, 2021 16:15
bump library-go
d48cbd4 
Signed-off-by: Antonio Ojea <aojea@redhat.com>
migrate to klog v2
61e3434 
Signed-off-by: Antonio Ojea <aojea@redhat.com>
@aojea
Copy link
Contributor Author

aojea commented Jul 28, 2021

/assign @sttts @deads2k

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@aojea: This pull request references Bugzilla bug 1984635, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1984635: use new default leader election values to handle SNO environments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 28, 2021
aojea
aojea commented Jul 28, 2021
View reviewed changes
vendor/github.com/openshift/library-go/pkg/config/leaderelection/leaderelection.go
if ret.LeaseDuration.Duration == 0 {
ret.LeaseDuration.Duration = 60 * time.Second
ret.LeaseDuration.Duration = 137 * time.Second
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new leader election values

@openshift-ci openshift-ci bot requested review from soltysh and sttts July 28, 2021 14:20
plumb context
9cf10e9 
Signed-off-by: Antonio Ojea <aojea@redhat.com>
@aojea
Copy link
Contributor Author

aojea commented Jul 28, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@aojea: This pull request references Bugzilla bug 1984635, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gangwgr

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 28, 2021
@openshift-ci openshift-ci bot requested a review from gangwgr July 28, 2021 15:57
@sttts
Copy link
Contributor

sttts commented Jul 29, 2021

/lgtm
/approve
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 75bed8e into openshift:master Jul 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

@aojea: All pull requests linked via external trackers have merged:

Bugzilla bug 1984635 has been moved to the MODIFIED state.

In response to this:

Bug 1984635: use new default leader election values to handle SNO environments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

@gangwgr gangwgr Awaiting requested review from gangwgr

Assignees

@sttts sttts

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aojea @sttts @openshift-bot @deads2k @openshift-merge-robot